Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Adds the presentation 8.8 docs #157765

Merged
merged 4 commits into from
May 16, 2023

Conversation

KOTungseth
Copy link
Contributor

@KOTungseth KOTungseth commented May 15, 2023

@KOTungseth KOTungseth added Team:Docs Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes v8.8.0 labels May 15, 2023
@KOTungseth KOTungseth self-assigned this May 15, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@github-actions
Copy link
Contributor

Documentation preview:

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling nit, otherwise lgtm! thanks for updating the docs!

docs/user/dashboard/dashboard.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@Heenawter Heenawter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two small nits - otherwise, LGTM 🎉

docs/user/dashboard/dashboard.asciidoc Outdated Show resolved Hide resolved
docs/user/dashboard/dashboard.asciidoc Outdated Show resolved Hide resolved
@KOTungseth KOTungseth merged commit 0689c63 into elastic:main May 16, 2023
@KOTungseth KOTungseth deleted the docs/8.8-presentation branch May 16, 2023 19:21
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 16, 2023
## Summary

Adds the docs for the following 8.8 Presentation docs:

- Unified dashboard settings:
elastic#153862
Docs preview:
https://kibana_157765.docs-preview.app.elstc.co/guide/en/kibana/master/dashboard.html#add-dashboard-settings

- Add reset button: elastic#154872
Docs preview:
https://kibana_157765.docs-preview.app.elstc.co/guide/en/kibana/master/dashboard.html#reset-the-dashboard

---------

Co-authored-by: Nick Peihl <[email protected]>
Co-authored-by: Hannah Mudge <[email protected]>
(cherry picked from commit 0689c63)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 16, 2023
# Backport

This will backport the following commits from `main` to `8.8`:
- [[DOCS] Adds the presentation 8.8 docs
(#157765)](#157765)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kaarina
Tungseth","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-16T19:21:01Z","message":"[DOCS]
Adds the presentation 8.8 docs (#157765)\n\n## Summary\r\n\r\nAdds the
docs for the following 8.8 Presentation docs:\r\n\r\n- Unified dashboard
settings:\r\nhttps://github.com//pull/153862\r\nDocs
preview:\r\nhttps://kibana_157765.docs-preview.app.elstc.co/guide/en/kibana/master/dashboard.html#add-dashboard-settings\r\n\r\n-
Add reset button: https://github.com/elastic/kibana/pull/154872\r\nDocs
preview:\r\nhttps://kibana_157765.docs-preview.app.elstc.co/guide/en/kibana/master/dashboard.html#reset-the-dashboard\r\n\r\n---------\r\n\r\nCo-authored-by:
Nick Peihl <[email protected]>\r\nCo-authored-by: Hannah Mudge
<[email protected]>","sha":"0689c638d3b3e4c8a9d00e1c2da2412a257771ce","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","Team:Presentation","release_note:skip","v8.8.0","v8.9.0"],"number":157765,"url":"https://github.com/elastic/kibana/pull/157765","mergeCommit":{"message":"[DOCS]
Adds the presentation 8.8 docs (#157765)\n\n## Summary\r\n\r\nAdds the
docs for the following 8.8 Presentation docs:\r\n\r\n- Unified dashboard
settings:\r\nhttps://github.com//pull/153862\r\nDocs
preview:\r\nhttps://kibana_157765.docs-preview.app.elstc.co/guide/en/kibana/master/dashboard.html#add-dashboard-settings\r\n\r\n-
Add reset button: https://github.com/elastic/kibana/pull/154872\r\nDocs
preview:\r\nhttps://kibana_157765.docs-preview.app.elstc.co/guide/en/kibana/master/dashboard.html#reset-the-dashboard\r\n\r\n---------\r\n\r\nCo-authored-by:
Nick Peihl <[email protected]>\r\nCo-authored-by: Hannah Mudge
<[email protected]>","sha":"0689c638d3b3e4c8a9d00e1c2da2412a257771ce"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157765","number":157765,"mergeCommit":{"message":"[DOCS]
Adds the presentation 8.8 docs (#157765)\n\n## Summary\r\n\r\nAdds the
docs for the following 8.8 Presentation docs:\r\n\r\n- Unified dashboard
settings:\r\nhttps://github.com//pull/153862\r\nDocs
preview:\r\nhttps://kibana_157765.docs-preview.app.elstc.co/guide/en/kibana/master/dashboard.html#add-dashboard-settings\r\n\r\n-
Add reset button: https://github.com/elastic/kibana/pull/154872\r\nDocs
preview:\r\nhttps://kibana_157765.docs-preview.app.elstc.co/guide/en/kibana/master/dashboard.html#reset-the-dashboard\r\n\r\n---------\r\n\r\nCo-authored-by:
Nick Peihl <[email protected]>\r\nCo-authored-by: Hannah Mudge
<[email protected]>","sha":"0689c638d3b3e4c8a9d00e1c2da2412a257771ce"}}]}]
BACKPORT-->

Co-authored-by: Kaarina Tungseth <[email protected]>
jasonrhodes pushed a commit that referenced this pull request May 17, 2023
## Summary

Adds the docs for the following 8.8 Presentation docs:

- Unified dashboard settings:
#153862
Docs preview:
https://kibana_157765.docs-preview.app.elstc.co/guide/en/kibana/master/dashboard.html#add-dashboard-settings

- Add reset button: #154872
Docs preview:
https://kibana_157765.docs-preview.app.elstc.co/guide/en/kibana/master/dashboard.html#reset-the-dashboard

---------

Co-authored-by: Nick Peihl <[email protected]>
Co-authored-by: Hannah Mudge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Docs Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.8.0 v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants