-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ALERT_CONTEXT to Metric Threshold Rule AAD documents #157755
Adding ALERT_CONTEXT to Metric Threshold Rule AAD documents #157755
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
acc.push(result[group].currentValue); | ||
if (result[group]) { | ||
acc.push(result[group].currentValue); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #155534
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
I just wanted to let you know that we already added an attributes for alert detail URL |
++ to Xavier's recommendation. I don't think that we should be putting the entire action context into the alert as it duplicates a lot of the information that we already have in the alert in different fields. I'd prefer we add additional fields to the alert to allow us to recreate the "context" in the flyout. If you feel strongly that the benefits we get from this approach outweigh the drawbacks, can we rename |
This is a follow up to this PR: #155327 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
We've decided to go a different direction |
Summary
This PR serializes the "action context" into
ALERT_CONTEXT
and stores it in the Alert-As-Data index. This will be used by the "alert detail page" to display group by details along with other information from the alert context.Fixes #155534
Fixes #154126