Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ALERT_CONTEXT to Metric Threshold Rule AAD documents #157755

Conversation

simianhacker
Copy link
Member

@simianhacker simianhacker commented May 15, 2023

Summary

This PR serializes the "action context" into ALERT_CONTEXT and stores it in the Alert-As-Data index. This will be used by the "alert detail page" to display group by details along with other information from the alert context.

image

Fixes #155534
Fixes #154126

@simianhacker simianhacker added v8.9.0 Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" labels May 15, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

acc.push(result[group].currentValue);
if (result[group]) {
acc.push(result[group].currentValue);
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes #155534

@simianhacker simianhacker marked this pull request as ready for review May 15, 2023 16:59
@simianhacker simianhacker requested a review from a team as a code owner May 15, 2023 16:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 400 404 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 480 484 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@XavierM
Copy link
Contributor

XavierM commented May 17, 2023

I just wanted to let you know that we already added an attributes for alert detail URL kibana.alert.url, I am wondering if we can build this context when you ask for an alert and use as much possible the ECS. Maybe I am not seeing the full picture here.

@kobelb
Copy link
Contributor

kobelb commented May 17, 2023

I just wanted to let you know that we already added an attributes for alert detail URL kibana.alert.url, I am wondering if we can build this context when you ask for an alert and use as much possible the ECS. Maybe I am not seeing the full picture here.

++ to Xavier's recommendation. I don't think that we should be putting the entire action context into the alert as it duplicates a lot of the information that we already have in the alert in different fields. I'd prefer we add additional fields to the alert to allow us to recreate the "context" in the flyout.

If you feel strongly that the benefits we get from this approach outweigh the drawbacks, can we rename kibana.alert.context to kibana.alert.observability.context to make it explicit that this field is only relevant to observability alerts?

@simianhacker
Copy link
Member Author

This is a follow up to this PR: #155327

Copy link
Contributor

@mohamedhamed-ahmed mohamedhamed-ahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mohamedhamed-ahmed mohamedhamed-ahmed self-requested a review May 30, 2023 14:13
@mohamedhamed-ahmed mohamedhamed-ahmed self-assigned this May 30, 2023
@simianhacker
Copy link
Member Author

We've decided to go a different direction

@simianhacker simianhacker deleted the issue-154126-ALERT_CONTEXT-for-MTR branch April 17, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment