[ResponseOps] es query rule params not compatible between 8.6 and 8.7 #157710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doakalexi
added
Team:ResponseOps
doakalexi
changed the title
|
Pinging @elastic/response-ops (Team:ResponseOps) |
pmuellr
approved these changes
May 15, 2023
ymao1
approved these changes
May 15, 2023
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 15, 2023
…elastic#157710) Resolves elastic#156856 ## Summary Adds a default value to `aggType` and `groupBy` fields ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 8ecd2d6)
kibanamachine
added a commit
that referenced
this pull request
May 15, 2023
…nd 8.7 (#157710) (#157775) # Backport This will backport the following commits from `main` to `8.8`: - [[ResponseOps] es query rule params not compatible between 8.6 and 8.7 (#157710)](#157710) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alexi Doak","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-15T17:08:30Z","message":"[ResponseOps] es query rule params not compatible between 8.6 and 8.7 (#157710)\n\nResolves https://github.com/elastic/kibana/issues/156856\r\n\r\n## Summary\r\n\r\nAdds a default value to `aggType` and `groupBy` fields \r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"8ecd2d67a02f9de2a0e4f8778dcca3781dceaa90","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:ResponseOps","v8.8.0","v8.9.0"],"number":157710,"url":"https://github.com/elastic/kibana/pull/157710","mergeCommit":{"message":"[ResponseOps] es query rule params not compatible between 8.6 and 8.7 (#157710)\n\nResolves https://github.com/elastic/kibana/issues/156856\r\n\r\n## Summary\r\n\r\nAdds a default value to `aggType` and `groupBy` fields \r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"8ecd2d67a02f9de2a0e4f8778dcca3781dceaa90"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157710","number":157710,"mergeCommit":{"message":"[ResponseOps] es query rule params not compatible between 8.6 and 8.7 (#157710)\n\nResolves https://github.com/elastic/kibana/issues/156856\r\n\r\n## Summary\r\n\r\nAdds a default value to `aggType` and `groupBy` fields \r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"8ecd2d67a02f9de2a0e4f8778dcca3781dceaa90"}}]}] BACKPORT--> Co-authored-by: Alexi Doak <[email protected]>
|
Thanks for fixing this so quickly, @doakalexi! |
|
Thank you! Any chance we get also a backport to 8.7.x? |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
doakalexi
added a commit
to doakalexi/kibana
that referenced
this pull request
May 16, 2023
…elastic#157710) Resolves elastic#156856 ## Summary Adds a default value to `aggType` and `groupBy` fields ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 8ecd2d6)
doakalexi
added a commit
that referenced
this pull request
May 16, 2023
…nd 8.7 (#157710) (#157874) # Backport This will backport the following commits from `main` to `8.7`: - [[ResponseOps] es query rule params not compatible between 8.6 and 8.7 (#157710)](#157710) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alexi Doak","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-15T17:08:30Z","message":"[ResponseOps] es query rule params not compatible between 8.6 and 8.7 (#157710)\n\nResolves https://github.com/elastic/kibana/issues/156856\r\n\r\n## Summary\r\n\r\nAdds a default value to `aggType` and `groupBy` fields \r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"8ecd2d67a02f9de2a0e4f8778dcca3781dceaa90","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:ResponseOps","v8.7.0","v8.8.0","v8.9.0"],"number":157710,"url":"https://github.com/elastic/kibana/pull/157710","mergeCommit":{"message":"[ResponseOps] es query rule params not compatible between 8.6 and 8.7 (#157710)\n\nResolves https://github.com/elastic/kibana/issues/156856\r\n\r\n## Summary\r\n\r\nAdds a default value to `aggType` and `groupBy` fields \r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"8ecd2d67a02f9de2a0e4f8778dcca3781dceaa90"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/157775","number":157775,"state":"MERGED","mergeCommit":{"sha":"f61bbf30093491919b757d54c2a520b0cb91e8f6","message":"[8.8] [ResponseOps] es query rule params not compatible between 8.6 and 8.7 (#157710) (#157775)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.8`:\n- [[ResponseOps] es query rule params not compatible between 8.6 and 8.7\n(#157710)](https://github.com/elastic/kibana/pull/157710)\n\n<!--- Backport version: 8.9.7 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Alexi\nDoak\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2023-05-15T17:08:30Z\",\"message\":\"[ResponseOps]\nes query rule params not compatible between 8.6 and 8.7\n(#157710)\\n\\nResolves\nhttps://github.com//issues/156856\\r\\n\\r\\n##\nSummary\\r\\n\\r\\nAdds a default value to `aggType` and `groupBy` fields\n\\r\\n\\r\\n\\r\\n### Checklist\\r\\n\\r\\n- [x] [Unit or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated or added to match the most common\nscenarios\",\"sha\":\"8ecd2d67a02f9de2a0e4f8778dcca3781dceaa90\",\"branchLabelMapping\":{\"^v8.9.0$\":\"main\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"bug\",\"release_note:skip\",\"Team:ResponseOps\",\"v8.8.0\",\"v8.9.0\"],\"number\":157710,\"url\":\"https://github.com/elastic/kibana/pull/157710\",\"mergeCommit\":{\"message\":\"[ResponseOps]\nes query rule params not compatible between 8.6 and 8.7\n(#157710)\\n\\nResolves\nhttps://github.com//issues/156856\\r\\n\\r\\n##\nSummary\\r\\n\\r\\nAdds a default value to `aggType` and `groupBy` fields\n\\r\\n\\r\\n\\r\\n### Checklist\\r\\n\\r\\n- [x] [Unit or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated or added to match the most common\nscenarios\",\"sha\":\"8ecd2d67a02f9de2a0e4f8778dcca3781dceaa90\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.8\"],\"targetPullRequestStates\":[{\"branch\":\"8.8\",\"label\":\"v8.8.0\",\"labelRegex\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"},{\"branch\":\"main\",\"label\":\"v8.9.0\",\"labelRegex\":\"^v8.9.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/157710\",\"number\":157710,\"mergeCommit\":{\"message\":\"[ResponseOps]\nes query rule params not compatible between 8.6 and 8.7\n(#157710)\\n\\nResolves\nhttps://github.com//issues/156856\\r\\n\\r\\n##\nSummary\\r\\n\\r\\nAdds a default value to `aggType` and `groupBy` fields\n\\r\\n\\r\\n\\r\\n### Checklist\\r\\n\\r\\n- [x] [Unit or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated or added to match the most common\nscenarios\",\"sha\":\"8ecd2d67a02f9de2a0e4f8778dcca3781dceaa90\"}}]}]\nBACKPORT-->\n\nCo-authored-by: Alexi Doak <[email protected]>"}},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157710","number":157710,"mergeCommit":{"message":"[ResponseOps] es query rule params not compatible between 8.6 and 8.7 (#157710)\n\nResolves https://github.com/elastic/kibana/issues/156856\r\n\r\n## Summary\r\n\r\nAdds a default value to `aggType` and `groupBy` fields \r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"8ecd2d67a02f9de2a0e4f8778dcca3781dceaa90"}}]}] BACKPORT-->
jasonrhodes
pushed a commit
that referenced
this pull request
May 17, 2023
…#157710) Resolves #156856 ## Summary Adds a default value to `aggType` and `groupBy` fields ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #156856
Summary
Adds a default value to
aggTypeandgroupByfieldsChecklist