Add SloGlobalDiagnosis check to SLO List and SLO Create pages

[CoenWarmer]

Resolves #157317

📝 Summary

This adds the usage of the SLO Global Diagnosis endpoint in the SLO app on the SLO Welcome and SLO Create pages.

If the endpoint returns an error, the user will receive a toast with more detailed information as to what is the cause of the issue.

On the Welcome page the Create SLO button will be disabled. When the user visits the Create page via URL she will be navigated back to the Welcome page.

✅ Checklist

• If a user has required cluster permissions, the user should be able to click the Create SLO button on the welcome page
• If a user has required cluster permissions, the user should be able to navigate to the Create SLO page
• If a user does not have required cluster permissions, the user should not be able to click the Create SLO button on the welcome page
• If a user does not have required cluster permissions, the user should be navigated to the Welcome page when the user attempts to visit the Create SLO page
• If a user does not have required cluster permissions, the user should receive a helpful error message.

[apmmachine]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[kdelemme]

this try catch is not needed if we are just throwing the error.

[CoenWarmer]

I think it is needed.

const sloResources = await getSloResourcesDiagnosis(esClient); throws an error when ES has insufficient permissions, so if we don't throw here this function returns a normal object:

return {
    licenseAndFeatures: { something },
    userPrivileges: { something },
  	sloResources: { message: 'Some error message', statusCode: 403, ...etc }
};

[kdelemme]

what does this thing do?

[CoenWarmer]

It's one of HAPI Boom's methods to auto-format the response:

Boom.failedDependency([message], [data])
Returns a 424 Failed Dependency error where:

message - optional message.
data - optional additional error data.
Boom.failedDependency('an external resource failed');
Generates the following response payload:

{
    "statusCode": 424,
    "error": "Failed Dependency",
    "message": "an external resource failed"
}

https://hapi.dev/module/boom/api/?v=10.0.1#boomfaileddependencymessage-data

[kdelemme]

So basically we rely on an error response coming from the API to consider the permission as insufficient?
I guess it works for now, but for 8.9 I would probably move this logic into the different SLO endpoints (create, update, etc..) and handle the 403 from there, returning a special error response, so we guarantee a universal experience on both UI and API.

[CoenWarmer]

Agree, this can be improved.

The bug report mentioned disabling the "Create SLO" button on the Welcome page when no permissions are found, so we at least need this call to do that, not only on mutating endpoints.

[kdelemme]

LGTM

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: f506486

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
observability	408	410	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
observability	972.1KB	972.9KB	+809.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
enterpriseSearch	19	21	+2
securitySolution	400	404	+4
total			+6

Total ESLint disabled count

id	before	after	diff
enterpriseSearch	20	22	+2
securitySolution	480	484	+4
total			+6

History

• 💔 Build #127408 failed fd81f81

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[kibanamachine]

💚 All backports created successfully

Status	Branch	Result
✅	8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation