Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move useTrackMetric hook usage to Observability Shared #157272

Merged
merged 7 commits into from
May 12, 2023

Conversation

CoenWarmer
Copy link
Contributor

@CoenWarmer CoenWarmer commented May 10, 2023

Resolves #157274

📝 Summary

This PR moves useTrackMetric usage in the Observability apps to Observability Shared.

More info in the issue description.

@CoenWarmer CoenWarmer requested review from a team as code owners May 10, 2023 13:47
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label May 10, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@CoenWarmer CoenWarmer added the release_note:skip Skip the PR/issue when compiling release notes label May 10, 2023
@CoenWarmer CoenWarmer force-pushed the chore/update-obs-hook-usage branch from ff5eb58 to 98a9613 Compare May 10, 2023 14:37
@CoenWarmer CoenWarmer requested a review from a team as a code owner May 10, 2023 14:37
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label May 10, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@CoenWarmer CoenWarmer marked this pull request as draft May 10, 2023 15:07
@CoenWarmer CoenWarmer marked this pull request as ready for review May 11, 2023 09:40
Copy link
Contributor

@benakansara benakansara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AO changes LGTM

@CoenWarmer
Copy link
Contributor Author

@elasticmachine merge upstream

1 similar comment
@CoenWarmer
Copy link
Contributor Author

@elasticmachine merge upstream

@crespocarlos crespocarlos self-requested a review May 11, 2023 14:49
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 409 408 -1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observability 562 549 -13

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.5MB 3.5MB +12.0B
infra 2.0MB 2.0MB +112.0B
monitoring 459.4KB 459.4KB +18.0B
observability 972.1KB 972.1KB +39.0B
synthetics 1.2MB 1.2MB +31.0B
ux 164.8KB 164.8KB +11.0B
total +223.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
observability 27 25 -2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
monitoring 24.1KB 24.2KB +149.0B
observability 57.0KB 55.8KB -1.1KB
ux 6.3KB 6.4KB +149.0B
total -836.0B
Unknown metric groups

API count

id before after diff
observability 568 555 -13

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
observability 35 33 -2
securitySolution 400 404 +4
total +4

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
observability 39 37 -2
securitySolution 480 484 +4
total +4

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@crespocarlos crespocarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Infra monitoring UI changes LGTM!

Copy link
Contributor

@awahab07 awahab07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Synthetics, Uptime and UX plugin changes LGTM.

@CoenWarmer CoenWarmer merged commit 62437bb into elastic:main May 12, 2023
@kibanamachine kibanamachine added v8.9.0 backport:skip This commit does not require backporting labels May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move useTrackMetric hook to Observability Shared
9 participants