WIP: Refactoring - cleaning up async/awaits #15707
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was under the impression that async/await couldn't be used in angular code. Did I miss some sort of discussion that resolved that issue? |
|
@trevan thx for the heads up, i wasn't aware of that issue. Do you know the exact limitations, and whom to talk about it? |
|
@nyurik, the original issue with async/await in angular is that it bypasses angular's digest loop and so changes done will not be caught by angular. I saw discussions about working around that (especially for shared code between angular and react). I did a quick search and found #13855 which has more discussion. I don't see any resolution there, though. |
|
thanks for explaining. This should probably be shelved until better time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.