Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.8] [Security Solution] Maintenance Window callout: Update tests to match the test plan (#156532) #156727

Merged
merged 1 commit into from
May 4, 2023
Merged

[8.8] [Security Solution] Maintenance Window callout: Update tests to match the test plan (#156532) #156727

merged 1 commit into from
May 4, 2023

Conversation

nikitaindik
Copy link
Contributor

Backport

This will backport the following commits from main to 8.8:

Questions ?

Please refer to the Backport tool documentation

@nikitaindik
[Security Solution] Maintenance Window callout: Update tests to match…
512fa13 
… the test plan (elastic#156532)

## Summary

This PR updates Maintenance Window callout tests to match the test plan.

Maintenance Window callout is shown on the Rules Management page when
there's a Maintenance Window running.

<img width="1260" alt="233624339-9c9b6e3e-9e5e-424d-9d19-9cd7d4e92259"
src="https://user-images.githubusercontent.com/15949146/235923634-53113720-d58a-4a15-b66b-b2008f80f035.png">

[**Test plan**
(internal)](https://docs.google.com/document/d/1NTTbV7FemZR8LVwWBbDW3Jji58Wy2-n-YGycD698RR8/edit?usp=sharing
)

[**Maintenance Window Callout
issue**](elastic#155099) with more info
about the feature

(cherry picked from commit 508ab65)
@nikitaindik nikitaindik enabled auto-merge (squash) May 4, 2023 19:18
@nikitaindik nikitaindik mentioned this pull request May 4, 2023
Merged
@nikitaindik nikitaindik self-assigned this May 4, 2023
@nikitaindik nikitaindik added the Team:Detection Rule Management Security Detection Rule Management Team label May 4, 2023
@nikitaindik nikitaindik merged commit f9f91d7 into elastic:8.8 May 4, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #3 / timeline flyout button the (+) button popover menu owns focus

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 479 482 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nikitaindik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikitaindik nikitaindik

Labels
backport Team:Detection Rule Management Security Detection Rule Management Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikitaindik @kibana-ci