Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.8] [RAM][Maintenance Window][8.8] Remove Extra Commas and Disable Fetch If No License (#156296) #156573

Merged
merged 2 commits into from
May 3, 2023

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.8:

Questions ?

Please refer to the Backport tool documentation

…If No License (elastic#156296)

## Summary

Remove some extra commas for the maintenance window no license prompt

![image](https://user-images.githubusercontent.com/74562234/235515841-1ea1da44-db5c-42c0-9e34-97ad017be474.png)

Also, disable fetch if the user does not have the correct license type,
this gets rid of the unnecessary error popover since the find
maintenance window API will reject these requests.

### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit f7881f6)
@JiaweiWu
Copy link
Contributor

JiaweiWu commented May 3, 2023

@elasticmachine merge upstream

@kibanamachine kibanamachine merged commit 7ae26ec into elastic:8.8 May 3, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
alerting 183.2KB 183.3KB +54.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 479 482 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @JiaweiWu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants