[Security Solution] [Fix] Alert Page Controls do not recover from invalid query. #156542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logeekal
added
release_note:fix
Team:Threat Hunting:Investigations
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
References to deprecated APIs
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 3, 2023
…alid query. (elastic#156542) ## Summary This PR handles elastic#156016 . Previously, if user supplied an invalid kql or lucene query, Alert Page controls will go in error state and not recover until user reloaded the page or navigated away and back to the Alert Page. This PR prevents Alert Page Controls going in that error state. | Before | After | |--|--| | <video src="https://user-images.githubusercontent.com/7485038/235931286-6da23567-4ae8-454a-92b8-a595a20f5655.mov" /> | <video src="https://user-images.githubusercontent.com/7485038/235930584-485df881-d22c-44f3-9d53-f673820eb673.mov" /> | ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit ff65ca4)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 3, 2023
…om invalid query. (#156542) (#156567) # Backport This will backport the following commits from `main` to `8.8`: - [[Security Solution] [Fix] Alert Page Controls do not recover from invalid query. (#156542)](#156542) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jatin Kathuria","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-03T14:57:11Z","message":"[Security Solution] [Fix] Alert Page Controls do not recover from invalid query. (#156542)\n\n## Summary\r\n\r\nThis PR handles #156016 .\r\n\r\nPreviously, if user supplied an invalid kql or lucene query, Alert Page\r\ncontrols will go in error state and not recover until user reloaded the\r\npage or navigated away and back to the Alert Page.\r\n\r\nThis PR prevents Alert Page Controls going in that error state.\r\n\r\n| Before | After |\r\n|--|--|\r\n| <video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/235931286-6da23567-4ae8-454a-92b8-a595a20f5655.mov\"\r\n/> | <video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/235930584-485df881-d22c-44f3-9d53-f673820eb673.mov\"\r\n/> |\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"ff65ca42f2f09589b09a8e61abe22a4a69885170","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Threat Hunting:Investigations","v8.8.0","v8.9.0"],"number":156542,"url":"https://github.com/elastic/kibana/pull/156542","mergeCommit":{"message":"[Security Solution] [Fix] Alert Page Controls do not recover from invalid query. (#156542)\n\n## Summary\r\n\r\nThis PR handles #156016 .\r\n\r\nPreviously, if user supplied an invalid kql or lucene query, Alert Page\r\ncontrols will go in error state and not recover until user reloaded the\r\npage or navigated away and back to the Alert Page.\r\n\r\nThis PR prevents Alert Page Controls going in that error state.\r\n\r\n| Before | After |\r\n|--|--|\r\n| <video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/235931286-6da23567-4ae8-454a-92b8-a595a20f5655.mov\"\r\n/> | <video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/235930584-485df881-d22c-44f3-9d53-f673820eb673.mov\"\r\n/> |\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"ff65ca42f2f09589b09a8e61abe22a4a69885170"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156542","number":156542,"mergeCommit":{"message":"[Security Solution] [Fix] Alert Page Controls do not recover from invalid query. (#156542)\n\n## Summary\r\n\r\nThis PR handles #156016 .\r\n\r\nPreviously, if user supplied an invalid kql or lucene query, Alert Page\r\ncontrols will go in error state and not recover until user reloaded the\r\npage or navigated away and back to the Alert Page.\r\n\r\nThis PR prevents Alert Page Controls going in that error state.\r\n\r\n| Before | After |\r\n|--|--|\r\n| <video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/235931286-6da23567-4ae8-454a-92b8-a595a20f5655.mov\"\r\n/> | <video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/235930584-485df881-d22c-44f3-9d53-f673820eb673.mov\"\r\n/> |\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"ff65ca42f2f09589b09a8e61abe22a4a69885170"}}]}] BACKPORT--> Co-authored-by: Jatin Kathuria <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR handles #156016 .
Previously, if user supplied an invalid kql or lucene query, Alert Page controls will go in error state and not recover until user reloaded the page or navigated away and back to the Alert Page.
This PR prevents Alert Page Controls going in that error state.
Screen.Recording.2023-05-03.at.15.32.37.mov
Screen.Recording.2023-05-03.at.15.28.37.mov
Checklist
Delete any items that are not applicable to this PR.