Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.8] [Defend Workflows][Bug] Case flyout z-index (#153219) #156505

Merged
merged 2 commits into from
May 3, 2023
Merged

[8.8] [Defend Workflows][Bug] Case flyout z-index (#153219) #156505

merged 2 commits into from
May 3, 2023

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.8:

Questions ?

Please refer to the Backport tool documentation

@szwarckonrad
[Defend Workflows][Bug] Case flyout z-index (elastic#153219)
445842f 
Fixes elastic/security-team#6228

5000 `z-index` set in `create-case-flyout-mask-overlay` is being
overwritten by `euiOverlayMask-belowHeader` with a value of 1000. This
causes **Case flyout** to be under the already opened **Osquery flyout**

This PR includes cleanup in flyouts renders - we removed unnecessary
`maskProps` as well as z-indexes that were explicitly set even though
flyout component manages them itself.

![test](https://user-images.githubusercontent.com/29123534/225292177-a08d3fb8-aad3-487b-a054-6cde6aec94d7.gif)

---------

Co-authored-by: Tomasz Ciecierski <[email protected]>
Co-authored-by: Tomasz Ciecierski <[email protected]>
Co-authored-by: Patryk Kopyciński <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit d8fe39c)
@kibanamachine kibanamachine enabled auto-merge (squash) May 3, 2023 10:38
@kibanamachine kibanamachine mentioned this pull request May 3, 2023
Merged
@kevinlog kevinlog disabled auto-merge May 3, 2023 11:27
@kevinlog kevinlog enabled auto-merge (squash) May 3, 2023 11:29
@banderror banderror mentioned this pull request May 3, 2023
Closed
@patrykkopycinski patrykkopycinski added the ci:skip-cypress-osquery Skips osquery cypress checks label May 3, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #3 / timeline flyout button the (+) button popover menu owns focus

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 3859 3860 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 376.8KB 376.6KB -190.0B
securitySolution 9.1MB 9.1MB -818.0B
total -1008.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 479 482 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @szwarckonrad

@kevinlog kevinlog merged commit b12b812 into elastic:8.8 May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@szwarckonrad szwarckonrad

Labels
backport ci:skip-cypress-osquery Skips osquery cypress checks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kibanamachine @kibana-ci @patrykkopycinski @szwarckonrad @kevinlog