Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.8] [SecuritySolution] Align no indices state with Kibana dashboard (#155990) #156456

Merged
merged 1 commit into from
May 3, 2023

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.8:

Questions ?

Please refer to the Backport tool documentation

…tic#155990)

## Summary

Steps to reproduce:
1. Make sure you have some data in Security Data View. Create a
dashboard that consumes Security Data View, save it and add a `Security
Solution` tag.
2. Delete the non-empty indices in Security Data View
3. Back to SecuritySolution > Dashboards, select the dashboard you
added.
4. This is the current indices not found UI you'd see:
<img width="2546" alt="dashboard_view_indices_notfound"
src="https://user-images.githubusercontent.com/6295984/234829440-842442e1-f09a-464e-a6c0-8761a3124791.png">

Expected:
- We should align the behaviour with Kibana dashboard when indices not
found:

<img width="2555" alt="Screenshot 2023-04-27 at 10 48 26"
src="https://user-images.githubusercontent.com/6295984/234829379-251fb621-e7cd-4788-a682-8a2bce25312a.png">

After:
<img width="2542" alt="Screenshot 2023-04-27 at 11 10 16"
src="https://user-images.githubusercontent.com/6295984/234832003-95f5c7e5-57d9-4424-b591-f512f365cda2.png">

(cherry picked from commit 12277ac)
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.1MB 9.1MB -182.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 479 482 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @angorayc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants