-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Anomaly Detection Settings: Fix key attribute for filter list table #156392
[ML] Anomaly Detection Settings: Fix key attribute for filter list table #156392
Conversation
Pinging @elastic/ml-ui (:ml) |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @walterra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM
…ble (elastic#156392) Fixes the React dev mode warning "Warning: Each child in a list should have a unique "key" prop." by adding a key attribute to the `DeleteFilterListModal` component. (cherry picked from commit 7a4ae72)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…ist table (#156392) (#156482) # Backport This will backport the following commits from `main` to `8.8`: - [[ML] Anomaly Detection Settings: Fix key attribute for filter list table (#156392)](#156392) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Walter Rafelsberger","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-03T08:33:11Z","message":"[ML] Anomaly Detection Settings: Fix key attribute for filter list table (#156392)\n\nFixes the React dev mode warning \"Warning: Each child in a list should\r\nhave a unique \"key\" prop.\" by adding a key attribute to the\r\n`DeleteFilterListModal` component.","sha":"7a4ae72bceb23c30f3287339621a66f80caf06c9","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug",":ml","Feature:Anomaly Detection","release_note:skip","v8.8.0","v8.9.0"],"number":156392,"url":"https://github.com/elastic/kibana/pull/156392","mergeCommit":{"message":"[ML] Anomaly Detection Settings: Fix key attribute for filter list table (#156392)\n\nFixes the React dev mode warning \"Warning: Each child in a list should\r\nhave a unique \"key\" prop.\" by adding a key attribute to the\r\n`DeleteFilterListModal` component.","sha":"7a4ae72bceb23c30f3287339621a66f80caf06c9"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156392","number":156392,"mergeCommit":{"message":"[ML] Anomaly Detection Settings: Fix key attribute for filter list table (#156392)\n\nFixes the React dev mode warning \"Warning: Each child in a list should\r\nhave a unique \"key\" prop.\" by adding a key attribute to the\r\n`DeleteFilterListModal` component.","sha":"7a4ae72bceb23c30f3287339621a66f80caf06c9"}}]}] BACKPORT--> Co-authored-by: Walter Rafelsberger <[email protected]>
Summary
Part of #148228.
Fixes the React dev mode warning "Warning: Each child in a list should have a unique "key" prop." by adding a key attribute to the
DeleteFilterListModal
component.Checklist