Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAM] Edit maintenance window feature privilege label #156295

Merged
merged 1 commit into from
May 2, 2023

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented May 1, 2023

Summary

Relates to #156191

This PR updates the feature name in the list of Kibana feature privileges from "Maintenance Window" to "Maintenance Windows", so that it matches the app label.

Screenshots

Before

image

After

image

@lcawl lcawl added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) ui-copy Review of UI copy with docs team is recommended backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.8.0 v8.9.0 labels May 1, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #48 / spaces api without security get can access default from within the default space "before all" hook for "should return 200 when referencing the default space implicitly"

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 479 482 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl marked this pull request as ready for review May 1, 2023 23:30
@lcawl lcawl requested a review from a team as a code owner May 1, 2023 23:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl merged commit 8da8f89 into elastic:main May 2, 2023
@lcawl lcawl deleted the maint-window-privilege branch May 2, 2023 14:24
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 2, 2023
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 2, 2023
…#156398)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[RAM] Edit maintenance window feature privilege label
(#156295)](#156295)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-02T14:24:38Z","message":"[RAM]
Edit maintenance window feature privilege label
(#156295)","sha":"8da8f89db15556ec405122a511ad40698ab808be","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","ui-copy","backport:prev-minor","v8.8.0","v8.9.0"],"number":156295,"url":"https://github.com/elastic/kibana/pull/156295","mergeCommit":{"message":"[RAM]
Edit maintenance window feature privilege label
(#156295)","sha":"8da8f89db15556ec405122a511ad40698ab808be"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156295","number":156295,"mergeCommit":{"message":"[RAM]
Edit maintenance window feature privilege label
(#156295)","sha":"8da8f89db15556ec405122a511ad40698ab808be"}}]}]
BACKPORT-->

Co-authored-by: Lisa Cawley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) ui-copy Review of UI copy with docs team is recommended v8.8.0 v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants