fixes angular vis type so it correctly propagates events up to visualize

[ppisljar]

fixes angular vis type so it correctly propagates events up to visualize

the update event was not correctly propagated up to visualize when calling updateState() from visualization if it was using angular visualization type.

the clone was there for historical reasons i guess, and should not be needed anymore.

[peteharverson]

LGTM.
Note I tested this by using the same edit in a 6.1.1 install I have running with the swimlane visualization (https://github.com/prelert/kibana-swimlane-vis) which is an AngularJS viz type, which I am currently upgrading to work in 6.x Kibana. This fixes the issue I was seeing previously, where a change to $scope.vis.aggs was not correctly updating the aggs in the vis.

[ppisljar]

jenkins, test this

[timroes]

With the removal of this, we don't need the clone function on Vis anymore. Could we remove it, the tests for it, also as far as see, it was the last usage of the uiState parameter to the Vis constructor.

I think regarding the amount of dead code we're already having, we might want to consider throwing this out directly :-)