[Enterprise Search] Show error panel on ELSER API call errors #156273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-ref HEAD~1..HEAD --fix'
…mjened/kibana into demjened/elser-error-handling
demjened
added
the
release_note:skip
joemcelroy
reviewed
May 2, 2023
x-pack/plugins/enterprise_search/public/applications/shared/flash_messages/handle_api_errors.ts
Show resolved
Hide resolved
joemcelroy
reviewed
May 2, 2023
...ise_search_content/components/search_index/pipelines/ml_inference/text_expansion_callout.tsx
Outdated
Show resolved
Hide resolved
joemcelroy
reviewed
May 2, 2023
...rise_search_content/components/search_index/pipelines/ml_inference/text_expansion_errors.tsx
Outdated
Show resolved
Hide resolved
TattdCodeMonkey
approved these changes
May 2, 2023
...earch_content/components/search_index/pipelines/ml_inference/text_expansion_callout_logic.ts
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 2, 2023
## Summary This PR adds generic error handling for API calls that manage the ELSER model: creation (download), fetching and starting the deployment. If an error occurs, the ELSER panel is replaced with the error panel. The user can navigate to the ML Notifications page with a link, which might contain diagnostic information about the error.  ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 5263339)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
demjened
changed the title
kibanamachine
added a commit
that referenced
this pull request
May 2, 2023
…156273) (#156448) # Backport This will backport the following commits from `main` to `8.8`: - [[Enterprise Search] Show error panel on API call errors (#156273)](#156273) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Adam Demjen","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-02T20:42:13Z","message":"[Enterprise Search] Show error panel on API call errors (#156273)\n\n## Summary\r\n\r\nThis PR adds generic error handling for API calls that manage the ELSER\r\nmodel: creation (download), fetching and starting the deployment. If an\r\nerror occurs, the ELSER panel is replaced with the error panel. The user\r\ncan navigate to the ML Notifications page with a link, which might\r\ncontain diagnostic information about the error.\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"52633391082d0332d0f41b45c81989e41f875ccf","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.8.0","v8.9.0"],"number":156273,"url":"https://github.com/elastic/kibana/pull/156273","mergeCommit":{"message":"[Enterprise Search] Show error panel on API call errors (#156273)\n\n## Summary\r\n\r\nThis PR adds generic error handling for API calls that manage the ELSER\r\nmodel: creation (download), fetching and starting the deployment. If an\r\nerror occurs, the ELSER panel is replaced with the error panel. The user\r\ncan navigate to the ML Notifications page with a link, which might\r\ncontain diagnostic information about the error.\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"52633391082d0332d0f41b45c81989e41f875ccf"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156273","number":156273,"mergeCommit":{"message":"[Enterprise Search] Show error panel on API call errors (#156273)\n\n## Summary\r\n\r\nThis PR adds generic error handling for API calls that manage the ELSER\r\nmodel: creation (download), fetching and starting the deployment. If an\r\nerror occurs, the ELSER panel is replaced with the error panel. The user\r\ncan navigate to the ML Notifications page with a link, which might\r\ncontain diagnostic information about the error.\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"52633391082d0332d0f41b45c81989e41f875ccf"}}]}] BACKPORT--> Co-authored-by: Adam Demjen <[email protected]>
\r\n\r\n\r\n###){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds generic error handling for API calls that manage the ELSER model: creation (download), fetching and starting the deployment. If an error occurs, the ELSER panel is replaced with the error panel. The user can navigate to the ML Notifications page with a link, which might contain diagnostic information about the error.
Checklist