-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Synthetics] Do not re-render embeddable visualizations on detail/history page onLoad
#156219
Merged
shahzad31
merged 9 commits into
elastic:main
from
justinkambic:155197/remove-loading-state-for-silent-update-on-detail-page
May 2, 2023
Merged
[Synthetics] Do not re-render embeddable visualizations on detail/history page onLoad
#156219
shahzad31
merged 9 commits into
elastic:main
from
justinkambic:155197/remove-loading-state-for-silent-update-on-detail-page
May 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinkambic
added
bug
Fixes for quality problems that affect the customer experience
Team:Uptime - DEPRECATED
Synthetics & RUM sub-team of Application Observability
release_note:skip
Skip the PR/issue when compiling release notes
v8.8.0
v8.9.0
labels
Apr 28, 2023
Pinging @elastic/uptime (Team:uptime) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
…oading-state-for-silent-update-on-detail-page
💚 Build Succeeded
Metrics [docs]Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
shahzad31
approved these changes
May 2, 2023
shahzad31
deleted the
155197/remove-loading-state-for-silent-update-on-detail-page
branch
May 2, 2023 06:50
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 2, 2023
…tory page `onLoad` (elastic#156219) Co-authored-by: shahzad31 <[email protected]> (cherry picked from commit 7b94718)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 2, 2023
…il/history page `onLoad` (#156219) (#156327) # Backport This will backport the following commits from `main` to `8.8`: - [[Synthetics] Do not re-render embeddable visualizations on detail/history page `onLoad` (#156219)](#156219) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Justin Kambic","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-02T06:50:02Z","message":"[Synthetics] Do not re-render embeddable visualizations on detail/history page `onLoad` (#156219)\n\nCo-authored-by: shahzad31 <[email protected]>","sha":"7b947188f222a81cc8481c1b34ededfdc4363ff0","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:uptime","release_note:skip","v8.8.0","v8.9.0"],"number":156219,"url":"https://github.com/elastic/kibana/pull/156219","mergeCommit":{"message":"[Synthetics] Do not re-render embeddable visualizations on detail/history page `onLoad` (#156219)\n\nCo-authored-by: shahzad31 <[email protected]>","sha":"7b947188f222a81cc8481c1b34ededfdc4363ff0"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156219","number":156219,"mergeCommit":{"message":"[Synthetics] Do not re-render embeddable visualizations on detail/history page `onLoad` (#156219)\n\nCo-authored-by: shahzad31 <[email protected]>","sha":"7b947188f222a81cc8481c1b34ededfdc4363ff0"}}]}] BACKPORT--> Co-authored-by: Justin Kambic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
release_note:skip
Skip the PR/issue when compiling release notes
Team:Uptime - DEPRECATED
Synthetics & RUM sub-team of Application Observability
v8.8.0
v8.9.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #155917.
This patch makes it so that our embeddables do not re-render on load. The autorefresh is needlessly destructive to the existing data, and with the high number of embeddables on the page it makes it difficult to track what's changed when the data updates.
This patch keeps the progress bar on load to signify the data will update, but it does not fully re-render the visualizations before rendering the updated data.
Before
After
Testing
Load up the detail view for a monitor and look for any visualization that replaces the viz with a loading spinner before rendering the updated data.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers