Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[drift] Changed default trial offset from 60 to 90 days per PM request. #156186

Merged
merged 2 commits into from
Apr 29, 2023

Conversation

petrklapka
Copy link
Member

@petrklapka petrklapka commented Apr 28, 2023

Summary

Changes the default trial offset used to display the Drift chat integration from 60 to 90 days.

Checklist

N/A

Risk Matrix

N/A

For maintainers

N/A

@petrklapka petrklapka requested a review from a team as a code owner April 28, 2023 15:16
@clintandrewhall clintandrewhall added review loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. v8.8.0 v8.9.0 Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) Team:Journey/Onboarding Platform Journey Onboarding team labels Apr 28, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-onboarding (Team:Journey/Onboarding)

@clintandrewhall clintandrewhall changed the title Changed default trial offset from 60 to 90 days per PM request. [drift] Changed default trial offset from 60 to 90 days per PM request. Apr 28, 2023
@clintandrewhall clintandrewhall added the Feature:Chat The integration of Live Chat (Drift) into Kibana. label Apr 28, 2023
@clintandrewhall
Copy link
Contributor

This change won't affect Cloud until 8.8 is released.

We should talk to @s-nel and team about adding xpack.cloud_integrations.chat.trialBuffer to the Cloud config for Drift.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 479 482 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clintandrewhall clintandrewhall merged commit fa8096c into elastic:main Apr 29, 2023
@clintandrewhall clintandrewhall added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 29, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 29, 2023
…t. (elastic#156186)

## Summary

Changes the default trial offset used to display the Drift chat
integration from 60 to 90 days.

### Checklist
N/A

### Risk Matrix
N/A

### For maintainers
N/A

(cherry picked from commit fa8096c)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit that referenced this pull request Apr 29, 2023
…t. (#156186)

## Summary

Changes the default trial offset used to display the Drift chat
integration from 60 to 90 days.

### Checklist
N/A

### Risk Matrix
N/A

### For maintainers
N/A

(cherry picked from commit fa8096c)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

kibanamachine added a commit that referenced this pull request Apr 29, 2023
…request. (#156186) (#156230)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[drift] Changed default trial offset from 60 to 90 days per PM
request. (#156186)](#156186)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Petr
Klapka","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-04-29T00:07:19Z","message":"[drift]
Changed default trial offset from 60 to 90 days per PM request.
(#156186)\n\n## Summary\r\n\r\nChanges the default trial offset used to
display the Drift chat\r\nintegration from 60 to 90 days.\r\n\r\n\r\n###
Checklist\r\nN/A\r\n\r\n### Risk Matrix\r\nN/A\r\n\r\n### For
maintainers\r\nN/A","sha":"fa8096cd8bcac0b93c4e8798a4a2ca069a4d42ed","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["review","loe:hours","release_note:skip","impact:medium","auto-backport","Team:SharedUX","Team:Journey/Onboarding","v8.8.0","Feature:Chat","v8.9.0"],"number":156186,"url":"https://github.com/elastic/kibana/pull/156186","mergeCommit":{"message":"[drift]
Changed default trial offset from 60 to 90 days per PM request.
(#156186)\n\n## Summary\r\n\r\nChanges the default trial offset used to
display the Drift chat\r\nintegration from 60 to 90 days.\r\n\r\n\r\n###
Checklist\r\nN/A\r\n\r\n### Risk Matrix\r\nN/A\r\n\r\n### For
maintainers\r\nN/A","sha":"fa8096cd8bcac0b93c4e8798a4a2ca069a4d42ed"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156186","number":156186,"mergeCommit":{"message":"[drift]
Changed default trial offset from 60 to 90 days per PM request.
(#156186)\n\n## Summary\r\n\r\nChanges the default trial offset used to
display the Drift chat\r\nintegration from 60 to 90 days.\r\n\r\n\r\n###
Checklist\r\nN/A\r\n\r\n### Risk Matrix\r\nN/A\r\n\r\n### For
maintainers\r\nN/A","sha":"fa8096cd8bcac0b93c4e8798a4a2ca069a4d42ed"}}]}]
BACKPORT-->

Co-authored-by: Petr Klapka <[email protected]>
kibanamachine added a commit that referenced this pull request Apr 29, 2023
…request. (#156186) (#156229)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[drift] Changed default trial offset from 60 to 90 days per PM
request. (#156186)](#156186)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Petr
Klapka","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-04-29T00:07:19Z","message":"[drift]
Changed default trial offset from 60 to 90 days per PM request.
(#156186)\n\n## Summary\r\n\r\nChanges the default trial offset used to
display the Drift chat\r\nintegration from 60 to 90 days.\r\n\r\n\r\n###
Checklist\r\nN/A\r\n\r\n### Risk Matrix\r\nN/A\r\n\r\n### For
maintainers\r\nN/A","sha":"fa8096cd8bcac0b93c4e8798a4a2ca069a4d42ed","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["review","loe:hours","release_note:skip","impact:medium","Team:SharedUX","Team:Journey/Onboarding","v8.8.0","Feature:Chat","v8.9.0"],"number":156186,"url":"https://github.com/elastic/kibana/pull/156186","mergeCommit":{"message":"[drift]
Changed default trial offset from 60 to 90 days per PM request.
(#156186)\n\n## Summary\r\n\r\nChanges the default trial offset used to
display the Drift chat\r\nintegration from 60 to 90 days.\r\n\r\n\r\n###
Checklist\r\nN/A\r\n\r\n### Risk Matrix\r\nN/A\r\n\r\n### For
maintainers\r\nN/A","sha":"fa8096cd8bcac0b93c4e8798a4a2ca069a4d42ed"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156186","number":156186,"mergeCommit":{"message":"[drift]
Changed default trial offset from 60 to 90 days per PM request.
(#156186)\n\n## Summary\r\n\r\nChanges the default trial offset used to
display the Drift chat\r\nintegration from 60 to 90 days.\r\n\r\n\r\n###
Checklist\r\nN/A\r\n\r\n### Risk Matrix\r\nN/A\r\n\r\n### For
maintainers\r\nN/A","sha":"fa8096cd8bcac0b93c4e8798a4a2ca069a4d42ed"}}]}]
BACKPORT-->

Co-authored-by: Petr Klapka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Chat The integration of Live Chat (Drift) into Kibana. impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Journey/Onboarding Platform Journey Onboarding team Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.8.0 v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants