Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SecuritySolution] Fix edit dashboard url #156160

Merged
merged 1 commit into from
May 2, 2023
Merged

[SecuritySolution] Fix edit dashboard url #156160

merged 1 commit into from
May 2, 2023

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Apr 28, 2023 •
edited by kibanamachine
Loading

Summary

It lands on the wrong page after clicking on Edit Dashboard button.

  • Steps to reproduce:
  1. Create a dashboard, save it and add a Security Solution tag.
  2. Back to SecuritySolution > Dashboards, select the dashboard you added.
  3. Click the Edit button at the top right corner.
  4. Observe that it lands at Kibana dashboard listing page.

Expect:
It should navigate to Kibana dashboard's edit mode.

Checklist

Delete any items that are not applicable to this PR.

@angorayc angorayc self-assigned this Apr 28, 2023
@angorayc angorayc added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore v8.8.0 Feature:Security Dashboards Security solution custom dashboards feature labels Apr 28, 2023
@angorayc angorayc changed the title fix edit dashboard url [SecuritySolution] Fix edit dashboard url Apr 28, 2023
@angorayc angorayc marked this pull request as ready for review April 28, 2023 10:41
@angorayc angorayc requested a review from a team as a code owner April 28, 2023 10:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #34 / spaces api without security update can update from the default space "before all" hook in "can update from the default space"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 3859 3858 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.1MB 9.1MB -311.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 479 482 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @angorayc

semd
semd approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thanks @angorayc

@angorayc angorayc merged commit eb2c8b8 into elastic:main May 2, 2023
@angorayc angorayc added the fixed label May 2, 2023
@kibanamachine kibanamachine mentioned this pull request May 2, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 2, 2023
@angorayc
[SecuritySolution] Fix edit dashboard url (elastic#156160)
3e33a4d 
## Summary

It lands on the wrong page after clicking on `Edit Dashboard` button.

- Steps to reproduce:

1. Create a dashboard, save it and add a Security Solution tag.
2. Back to SecuritySolution > Dashboards, select the dashboard you
added.
3. Click the `Edit` button at the top right corner.
4. Observe that it lands at Kibana dashboard listing page.

Expect:
It should navigate to Kibana dashboard's edit mode.

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit eb2c8b8)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 2, 2023
@kibanamachine @angorayc
[8.8] [SecuritySolution] Fix edit dashboard url (#156160) (#156339)
4c055e0 
# Backport

This will backport the following commits from `main` to `8.8`:
- [[SecuritySolution] Fix edit dashboard url
(#156160)](#156160)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Angela
Chuang","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-02T09:26:32Z","message":"[SecuritySolution]
Fix edit dashboard url (#156160)\n\n## Summary\r\n\r\nIt lands on the
wrong page after clicking on `Edit Dashboard` button.\r\n\r\n- Steps to
reproduce:\r\n\r\n1. Create a dashboard, save it and add a Security
Solution tag.\r\n2. Back to SecuritySolution > Dashboards, select the
dashboard you\r\nadded.\r\n3. Click the `Edit` button at the top right
corner.\r\n4. Observe that it lands at Kibana dashboard listing
page.\r\n\r\nExpect:\r\nIt should navigate to Kibana dashboard's edit
mode.\r\n\r\n### Checklist\r\n\r\nDelete any items that are not
applicable to this PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"eb2c8b8fac7b77ba03ecf2517a25345cf9a7bb94","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Threat
Hunting","fixed","Team: SecuritySolution","Team:Threat
Hunting:Explore","v8.8.0","Feature:Security
Dashboards","v8.9.0"],"number":156160,"url":"https://github.com/elastic/kibana/pull/156160","mergeCommit":{"message":"[SecuritySolution]
Fix edit dashboard url (#156160)\n\n## Summary\r\n\r\nIt lands on the
wrong page after clicking on `Edit Dashboard` button.\r\n\r\n- Steps to
reproduce:\r\n\r\n1. Create a dashboard, save it and add a Security
Solution tag.\r\n2. Back to SecuritySolution > Dashboards, select the
dashboard you\r\nadded.\r\n3. Click the `Edit` button at the top right
corner.\r\n4. Observe that it lands at Kibana dashboard listing
page.\r\n\r\nExpect:\r\nIt should navigate to Kibana dashboard's edit
mode.\r\n\r\n### Checklist\r\n\r\nDelete any items that are not
applicable to this PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"eb2c8b8fac7b77ba03ecf2517a25345cf9a7bb94"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156160","number":156160,"mergeCommit":{"message":"[SecuritySolution]
Fix edit dashboard url (#156160)\n\n## Summary\r\n\r\nIt lands on the
wrong page after clicking on `Edit Dashboard` button.\r\n\r\n- Steps to
reproduce:\r\n\r\n1. Create a dashboard, save it and add a Security
Solution tag.\r\n2. Back to SecuritySolution > Dashboards, select the
dashboard you\r\nadded.\r\n3. Click the `Edit` button at the top right
corner.\r\n4. Observe that it lands at Kibana dashboard listing
page.\r\n\r\nExpect:\r\nIt should navigate to Kibana dashboard's edit
mode.\r\n\r\n### Checklist\r\n\r\nDelete any items that are not
applicable to this PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"eb2c8b8fac7b77ba03ecf2517a25345cf9a7bb94"}}]}]
BACKPORT-->

Co-authored-by: Angela Chuang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semd semd semd approved these changes

Assignees

@angorayc angorayc

Labels
bug Fixes for quality problems that affect the customer experience Feature:Security Dashboards Security solution custom dashboards feature fixed release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.8.0 v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@angorayc @elasticmachine @kibana-ci @kibanamachine @semd