Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SLO] Update link to documentation #156139

Merged
merged 1 commit into from
Apr 28, 2023
Merged

[SLO] Update link to documentation #156139

merged 1 commit into from
Apr 28, 2023

Conversation

CoenWarmer
Copy link
Contributor

@CoenWarmer CoenWarmer commented Apr 28, 2023 •
edited by kibanamachine
Loading

Resolves #147749

📝 Summary

This updates the link to the SLO documentation on the SLO welcome screen.

@CoenWarmer CoenWarmer requested a review from a team as a code owner April 28, 2023 08:18
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@CoenWarmer CoenWarmer added backport release_note:skip Skip the PR/issue when compiling release notes v8.8.0 labels Apr 28, 2023
@CoenWarmer CoenWarmer enabled auto-merge (squash) April 28, 2023 08:38
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 967.1KB 967.1KB +61.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 479 482 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@CoenWarmer CoenWarmer merged commit 8c87a3f into elastic:main Apr 28, 2023
@CoenWarmer CoenWarmer deleted the feat/add-slo-doc-url branch April 28, 2023 09:19
@kibanamachine kibanamachine mentioned this pull request Apr 28, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 28, 2023
@CoenWarmer
[SLO] Update link to documentation (elastic#156139)
3070858 
(cherry picked from commit 8c87a3f)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 28, 2023
@kibanamachine @CoenWarmer
[8.8] [SLO] Update link to documentation (#156139) (#156149)
c7cc732 
# Backport

This will backport the following commits from `main` to `8.8`:
- [[SLO] Update link to documentation
(#156139)](#156139)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Coen
Warmer","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-04-28T09:17:42Z","message":"[SLO]
Update link to documentation
(#156139)","sha":"8c87a3f75125e44a88abbae632372f552c4d0d58","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v8.8.0","v8.9.0"],"number":156139,"url":"https://github.com/elastic/kibana/pull/156139","mergeCommit":{"message":"[SLO]
Update link to documentation
(#156139)","sha":"8c87a3f75125e44a88abbae632372f552c4d0d58"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156139","number":156139,"mergeCommit":{"message":"[SLO]
Update link to documentation
(#156139)","sha":"8c87a3f75125e44a88abbae632372f552c4d0d58"}}]}]
BACKPORT-->

Co-authored-by: Coen Warmer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benakansara benakansara benakansara approved these changes

Assignees
No one assigned
Labels
backport release_note:skip Skip the PR/issue when compiling release notes v8.8.0 v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SLO] Add documentation for SLO functionality
5 participants
@CoenWarmer @apmmachine @kibana-ci @kibanamachine @benakansara