Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[D4C] Fix to unused selector badge showing when selector used as exclude #156122

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

mitodrummer
Copy link
Contributor

@mitodrummer mitodrummer commented Apr 27, 2023

Summary

Defend for containers (policy UI) fix:

  • Fix to unused selector badge showing when selector used as exclude

@mitodrummer mitodrummer added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Team: Cloud Native Integrations v8.8.0 labels Apr 27, 2023
@mitodrummer mitodrummer requested review from norrietaylor and a team April 27, 2023 22:16
@mitodrummer mitodrummer enabled auto-merge (squash) April 27, 2023 22:17
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudDefend 256.8KB 256.9KB +86.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 479 482 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mitodrummer mitodrummer merged commit 69755a9 into elastic:main Apr 27, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 27, 2023
…ude (elastic#156122)

## Summary

Defend for containers (policy UI) fix:
- Fix to unused selector badge showing when selector used as exclude

(cherry picked from commit 69755a9)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 28, 2023
…s exclude (#156122) (#156124)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[D4C] Fix to unused selector badge showing when selector used as
exclude (#156122)](#156122)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Karl
Godard","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-04-27T23:23:51Z","message":"[D4C]
Fix to unused selector badge showing when selector used as exclude
(#156122)\n\n## Summary\r\n\r\nDefend for containers (policy UI)
fix:\r\n- Fix to unused selector badge showing when selector used as
exclude","sha":"69755a9ad868c87a09d54a9ebe9b6a77b835dcc8","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:prev-minor","Team:
Cloud Native
Integrations","v8.8.0","v8.9.0"],"number":156122,"url":"https://github.com/elastic/kibana/pull/156122","mergeCommit":{"message":"[D4C]
Fix to unused selector badge showing when selector used as exclude
(#156122)\n\n## Summary\r\n\r\nDefend for containers (policy UI)
fix:\r\n- Fix to unused selector badge showing when selector used as
exclude","sha":"69755a9ad868c87a09d54a9ebe9b6a77b835dcc8"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156122","number":156122,"mergeCommit":{"message":"[D4C]
Fix to unused selector badge showing when selector used as exclude
(#156122)\n\n## Summary\r\n\r\nDefend for containers (policy UI)
fix:\r\n- Fix to unused selector badge showing when selector used as
exclude","sha":"69755a9ad868c87a09d54a9ebe9b6a77b835dcc8"}}]}]
BACKPORT-->

Co-authored-by: Karl Godard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:fix v8.8.0 v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants