Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cases] Edit labels for file attachments #156026

Merged
merged 7 commits into from
May 2, 2023
Merged

[Cases] Edit labels for file attachments #156026

merged 7 commits into from
May 2, 2023

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Apr 27, 2023 •
edited by kibanamachine
Loading

Summary

This PR fixes the capitalization of some labels within Stack Management > Cases to align with the EUI guidelines

Relates to #154881

Screenshots

Before

image

After

image

@lcawl lcawl added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature ui-copy Review of UI copy with docs team is recommended v8.8.0 v8.9.0 labels Apr 27, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@adcoelho
Copy link
Contributor

Some of these are my fault 😅 I think some file jest tests are now expected to break

@lcawl
Copy link
Contributor Author

lcawl commented Apr 27, 2023

Some of these are my fault 😅 I think some file jest tests are now expected to break

Ah okay, if you want me to wait just let me know.

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 479 482 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl marked this pull request as ready for review May 2, 2023 14:34
@lcawl lcawl requested a review from a team as a code owner May 2, 2023 14:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@lcawl lcawl added the release_note:skip Skip the PR/issue when compiling release notes label May 2, 2023
@lcawl lcawl merged commit 30eb413 into elastic:main May 2, 2023
@lcawl lcawl deleted the case-files branch May 2, 2023 14:49
@lcawl lcawl mentioned this pull request May 2, 2023
Merged
lcawl added a commit to lcawl/kibana that referenced this pull request May 2, 2023
@lcawl
[Cases] Edit labels for file attachments (elastic#156026)
51d1a17 
(cherry picked from commit 30eb413)
@lcawl
Copy link
Contributor Author

lcawl commented May 2, 2023

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request May 2, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 2, 2023
@lcawl
[Cases] Edit labels for file attachments (elastic#156026)
84e8864 
(cherry picked from commit 30eb413)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit that referenced this pull request May 2, 2023
@lcawl
[8.8] [Cases] Edit labels for file attachments (#156026) (#156405)
ab23724 
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Cases] Edit labels for file attachments
(#156026)](#156026)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-02T14:49:53Z","message":"[Cases]
Edit labels for file attachments
(#156026)","sha":"30eb413215cf87f96ba5f58e562a7f9b2fbf7241","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","Feature:Cases","ui-copy","v8.8.0","v8.9.0"],"number":156026,"url":"https://github.com/elastic/kibana/pull/156026","mergeCommit":{"message":"[Cases]
Edit labels for file attachments
(#156026)","sha":"30eb413215cf87f96ba5f58e562a7f9b2fbf7241"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156026","number":156026,"mergeCommit":{"message":"[Cases]
Edit labels for file attachments
(#156026)","sha":"30eb413215cf87f96ba5f58e562a7f9b2fbf7241"}}]}]
BACKPORT-->
kibanamachine added a commit that referenced this pull request May 2, 2023
@kibanamachine @lcawl
[8.8] [Cases] Edit labels for file attachments (#156026) (#156406)
3d84be9 
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Cases] Edit labels for file attachments
(#156026)](#156026)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-02T14:49:53Z","message":"[Cases]
Edit labels for file attachments
(#156026)","sha":"30eb413215cf87f96ba5f58e562a7f9b2fbf7241","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","Feature:Cases","ui-copy","v8.8.0","v8.9.0"],"number":156026,"url":"https://github.com/elastic/kibana/pull/156026","mergeCommit":{"message":"[Cases]
Edit labels for file attachments
(#156026)","sha":"30eb413215cf87f96ba5f58e562a7f9b2fbf7241"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156026","number":156026,"mergeCommit":{"message":"[Cases]
Edit labels for file attachments
(#156026)","sha":"30eb413215cf87f96ba5f58e562a7f9b2fbf7241"}}]}]
BACKPORT-->

Co-authored-by: Lisa Cawley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adcoelho adcoelho adcoelho approved these changes

Assignees
No one assigned
Labels
Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) ui-copy Review of UI copy with docs team is recommended v8.8.0 v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lcawl @apmmachine @adcoelho @kibana-ci @elasticmachine @kibanamachine