-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enterprise Search] Add Production Model Name to Allowed List for ELSER API Endpoints #156020
Merged
markjhoy
merged 3 commits into
elastic:main
from
markjhoy:markjhoy/add_ELSER_modelname_to_allowed_names
Apr 27, 2023
Merged
[Enterprise Search] Add Production Model Name to Allowed List for ELSER API Endpoints #156020
markjhoy
merged 3 commits into
elastic:main
from
markjhoy:markjhoy/add_ELSER_modelname_to_allowed_names
Apr 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markjhoy
added
release_note:feature
Makes this part of the condensed release notes
Team:EnterpriseSearch
v8.8.0
labels
Apr 27, 2023
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
joemcelroy
approved these changes
Apr 27, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 27, 2023
…ER API Endpoints (elastic#156020) ## Summary Small PR to add the production model name to the `acceptableModelNames` list that the Enteprise Search 1-Click deploy API endpoints use to check to ensure we have a known, valid model name. ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit fbe3aa3)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 27, 2023
…or ELSER API Endpoints (#156020) (#156062) # Backport This will backport the following commits from `main` to `8.8`: - [[Enterprise Search] Add Production Model Name to Allowed List for ELSER API Endpoints (#156020)](#156020) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Mark J. Hoy","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-04-27T17:22:30Z","message":"[Enterprise Search] Add Production Model Name to Allowed List for ELSER API Endpoints (#156020)\n\n## Summary\r\n\r\nSmall PR to add the production model name to the `acceptableModelNames`\r\nlist that the Enteprise Search 1-Click deploy API endpoints use to check\r\nto ensure we have a known, valid model name.\r\n\r\n### Checklist\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"fbe3aa36b31c0e6499d03b6afb14d4d628d05312","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:feature","Team:EnterpriseSearch","v8.8.0","v8.9.0"],"number":156020,"url":"https://github.com/elastic/kibana/pull/156020","mergeCommit":{"message":"[Enterprise Search] Add Production Model Name to Allowed List for ELSER API Endpoints (#156020)\n\n## Summary\r\n\r\nSmall PR to add the production model name to the `acceptableModelNames`\r\nlist that the Enteprise Search 1-Click deploy API endpoints use to check\r\nto ensure we have a known, valid model name.\r\n\r\n### Checklist\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"fbe3aa36b31c0e6499d03b6afb14d4d628d05312"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156020","number":156020,"mergeCommit":{"message":"[Enterprise Search] Add Production Model Name to Allowed List for ELSER API Endpoints (#156020)\n\n## Summary\r\n\r\nSmall PR to add the production model name to the `acceptableModelNames`\r\nlist that the Enteprise Search 1-Click deploy API endpoints use to check\r\nto ensure we have a known, valid model name.\r\n\r\n### Checklist\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"fbe3aa36b31c0e6499d03b6afb14d4d628d05312"}}]}] BACKPORT--> Co-authored-by: Mark J. Hoy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:feature
Makes this part of the condensed release notes
Team:EnterpriseSearch
v8.8.0
v8.9.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Small PR to add the production model name to the
acceptableModelNames
list that the Enteprise Search 1-Click deploy API endpoints use to check to ensure we have a known, valid model name.Checklist