Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Search] Enable converting native connector to custom #155853

Merged
merged 5 commits into from
Apr 27, 2023

Conversation

sphilipse
Copy link
Member

@sphilipse sphilipse commented Apr 26, 2023

Summary

This adds the ability to convert a native connector to a customized connector.

@sphilipse sphilipse added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.8.0 labels Apr 26, 2023
@sphilipse sphilipse requested review from a team April 26, 2023 10:19
@sphilipse sphilipse requested a review from a team as a code owner April 26, 2023 10:19
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sphilipse There's one doclink change required.

Co-authored-by: Liam Thompson <[email protected]>
@sphilipse sphilipse requested a review from leemthompo April 26, 2023 12:37
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doclink LG™️

Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doclink LGTM

Copy link
Member

@efegurkan efegurkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

There are some typos left, otherwise good.

@sphilipse sphilipse enabled auto-merge (squash) April 27, 2023 15:05
@sphilipse
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 2069 2072 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.3MB 2.3MB +3.0KB
lists 157.4KB 157.5KB +63.0B
total +3.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 360.9KB 360.9KB +63.0B
enterpriseSearch 31.5KB 31.7KB +117.0B
total +180.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 479 482 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sphilipse sphilipse merged commit e44087a into elastic:main Apr 27, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 27, 2023
…stic#155853)

## Summary

This adds the ability to convert a native connector to a customized
connector.

---------

Co-authored-by: Liam Thompson <[email protected]>
(cherry picked from commit e44087a)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 27, 2023
#155853) (#156063)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[Enterprise Search] Enable converting native connector to custom
(#155853)](#155853)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sander
Philipse","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-04-27T17:23:14Z","message":"[Enterprise
Search] Enable converting native connector to custom (#155853)\n\n##
Summary\r\n\r\nThis adds the ability to convert a native connector to a
customized\r\nconnector.\r\n\r\n---------\r\n\r\nCo-authored-by: Liam
Thompson
<[email protected]>","sha":"e44087a06d5660690b0e31646b5c902ab115d6eb","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.8.0","v8.9.0"],"number":155853,"url":"https://github.com/elastic/kibana/pull/155853","mergeCommit":{"message":"[Enterprise
Search] Enable converting native connector to custom (#155853)\n\n##
Summary\r\n\r\nThis adds the ability to convert a native connector to a
customized\r\nconnector.\r\n\r\n---------\r\n\r\nCo-authored-by: Liam
Thompson
<[email protected]>","sha":"e44087a06d5660690b0e31646b5c902ab115d6eb"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155853","number":155853,"mergeCommit":{"message":"[Enterprise
Search] Enable converting native connector to custom (#155853)\n\n##
Summary\r\n\r\nThis adds the ability to convert a native connector to a
customized\r\nconnector.\r\n\r\n---------\r\n\r\nCo-authored-by: Liam
Thompson
<[email protected]>","sha":"e44087a06d5660690b0e31646b5c902ab115d6eb"}}]}]
BACKPORT-->

Co-authored-by: Sander Philipse <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.8.0 v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants