-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enterprise Search] Enable converting native connector to custom #155853
[Enterprise Search] Enable converting native connector to custom #155853
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sphilipse There's one doclink change required.
Co-authored-by: Liam Thompson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doclink LG™️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doclink LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There are some typos left, otherwise good.
...ntent/components/search_index/connector/native_connector_configuration/convert_connector.tsx
Outdated
Show resolved
Hide resolved
...ntent/components/search_index/connector/native_connector_configuration/convert_connector.tsx
Outdated
Show resolved
Hide resolved
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
…stic#155853) ## Summary This adds the ability to convert a native connector to a customized connector. --------- Co-authored-by: Liam Thompson <[email protected]> (cherry picked from commit e44087a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
#155853) (#156063) # Backport This will backport the following commits from `main` to `8.8`: - [[Enterprise Search] Enable converting native connector to custom (#155853)](#155853) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sander Philipse","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-04-27T17:23:14Z","message":"[Enterprise Search] Enable converting native connector to custom (#155853)\n\n## Summary\r\n\r\nThis adds the ability to convert a native connector to a customized\r\nconnector.\r\n\r\n---------\r\n\r\nCo-authored-by: Liam Thompson <[email protected]>","sha":"e44087a06d5660690b0e31646b5c902ab115d6eb","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.8.0","v8.9.0"],"number":155853,"url":"https://github.com/elastic/kibana/pull/155853","mergeCommit":{"message":"[Enterprise Search] Enable converting native connector to custom (#155853)\n\n## Summary\r\n\r\nThis adds the ability to convert a native connector to a customized\r\nconnector.\r\n\r\n---------\r\n\r\nCo-authored-by: Liam Thompson <[email protected]>","sha":"e44087a06d5660690b0e31646b5c902ab115d6eb"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155853","number":155853,"mergeCommit":{"message":"[Enterprise Search] Enable converting native connector to custom (#155853)\n\n## Summary\r\n\r\nThis adds the ability to convert a native connector to a customized\r\nconnector.\r\n\r\n---------\r\n\r\nCo-authored-by: Liam Thompson <[email protected]>","sha":"e44087a06d5660690b0e31646b5c902ab115d6eb"}}]}] BACKPORT--> Co-authored-by: Sander Philipse <[email protected]>
Summary
This adds the ability to convert a native connector to a customized connector.