Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CollapsibleNav] Make CollapsibleNav Items Accessible on Small Screens and In Browsers with High Zoom #155817

Merged
merged 12 commits into from
May 1, 2023
Merged

[CollapsibleNav] Make CollapsibleNav Items Accessible on Small Screens and In Browsers with High Zoom #155817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
27c3d68
[CollapsibleNav] Add a styling condition to ensure that Collapsible N…
breehall Apr 26, 2023
26b5e70
Merge branch 'main' into collapsible-nav
kibanamachine Apr 26, 2023
0b570c0
[PR Comments] Create an target specific classes for the KbnSolutionsC…
breehall Apr 27, 2023
99146e8
Merge branch 'collapsible-nav' of github.com:breehall/kibana into col…
breehall Apr 27, 2023
3e633c9
Update snapshot for collapsible nav. New class names were added to el…
breehall Apr 27, 2023
09dd287
Added the euiYScroll utility that was removed
breehall Apr 27, 2023
6d6308a
Lint
breehall Apr 27, 2023
cddd691
Update packages/core/chrome/core-chrome-browser-internal/src/ui/heade…
breehall Apr 27, 2023
6634af5
Update packages/core/chrome/core-chrome-browser-internal/src/ui/heade…
breehall Apr 27, 2023
eb37be6
Reorganize Sass per PR feedback
breehall Apr 27, 2023
22a4857
Update packages/core/chrome/core-chrome-browser-internal/src/ui/heade…
breehall Apr 27, 2023
8677243
Merge branch 'main' into collapsible-nav
kibanamachine Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...me/core-chrome-browser-internal/src/ui/header/__snapshots__/collapsible_nav.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 20 additions & 0 deletions packages/core/chrome/core-chrome-browser-internal/src/ui/header/collapsible_nav.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,29 @@
$screenHeightBreakpoint: $euiSize * 15;

.kbnCollapsibleNav {
@media (max-height: $screenHeightBreakpoint) {
overflow-y: auto;
}
}

.kbnCollapsibleNav__recentsListGroup {
@include euiYScroll;
max-height: $euiSize * 10;
margin-right: -$euiSizeS;
}

.kbnCollapsibleNav__solutions {
@include euiYScroll;

/**
* Allows the solutions nav group to be viewed on
* very small screen sizes and when the browser Zoom is high
*/
@media (max-height: $screenHeightBreakpoint) {
flex: 1 0 auto;
}
}

/**
* 1. Increase the hit area of the link (anchor)
* 2. Only show the text underline when hovering on the text/anchor portion
Expand Down
3 changes: 2 additions & 1 deletion packages/core/chrome/core-chrome-browser-internal/src/ui/header/collapsible_nav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ export function CollapsibleNav({
button={button}
ownFocus={false}
size={248}
className="kbnCollapsibleNav"
>
{customNavLink && (
<>
Expand Down Expand Up @@ -280,7 +281,7 @@ export function CollapsibleNav({

<EuiHorizontalRule margin="none" />

<EuiFlexItem className="eui-yScroll">
<EuiFlexItem className="kbnCollapsibleNav__solutions">
{/* Kibana, Observability, Security, and Management sections */}
{orderedCategories.map((categoryName) => {
const category = categoryDictionary[categoryName]!;
Expand Down