Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search Application] Update pageTemplate header to grey and rename nav item to "Search preview" #155795

Merged
merged 11 commits into from
Apr 27, 2023
Merged

[Search Application] Update pageTemplate header to grey and rename nav item to "Search preview" #155795

merged 11 commits into from
Apr 27, 2023

Conversation

saarikabhasi
Copy link
Member

@saarikabhasi saarikabhasi commented Apr 25, 2023 •
edited by kibanamachine
Loading

Summary

  • Rename nav item from "Preview" to "Search Preview"
  • Update page Header to grey

Screenshots

Search preview

Content

Connect

@saarikabhasi saarikabhasi added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Apr 25, 2023
@saarikabhasi saarikabhasi force-pushed the search-app-pageTemplate-cleanups branch from 3c59244 to f132216 Compare April 25, 2023 21:44
@saarikabhasi saarikabhasi marked this pull request as ready for review April 25, 2023 21:44
@saarikabhasi saarikabhasi requested a review from a team as a code owner April 25, 2023 21:44
@saarikabhasi saarikabhasi requested a review from a team April 25, 2023 21:44
TattdCodeMonkey
TattdCodeMonkey reviewed Apr 25, 2023
View reviewed changes
...blic/applications/enterprise_search_content/components/engine/search_application_layout.scss Outdated
@@ -0,0 +1,5 @@

.searchApplciationHeaderBackgroundColor {
background-color: rgba(247, 248, 252, 1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be an variable from EUI? cc @daveyholler

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find a EUI variable for "subdued". As per the design it's useEuiBackgroundColor('subdued')

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to use $euiColorLightShade for this. The color isn't actually called subdued, but the light shade is the background color for a subdued panel.

Copy link
Member Author

@saarikabhasi saarikabhasi Apr 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think $euiColorLightestShade is closest to subdued as $euiColorLightShade is little more of dark shade

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Page with background color $euiColorLightestShade

Screenshot 2023-04-26 at 9 39 39 AM

cc: @julianrosado WDYT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩 Beautiful!

sloanelybutsurely
sloanelybutsurely approved these changes Apr 27, 2023
View reviewed changes
Copy link

@sloanelybutsurely sloanelybutsurely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with proposed change to use EUI color instead of rgba literal

@saarikabhasi saarikabhasi added Team:EnterpriseSearch v8.8.0 v8.9.0 and removed backport:skip This commit does not require backporting labels Apr 27, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 2069 2074 +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.3MB 2.3MB +1.1KB
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 479 482 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

daveyholler
daveyholler approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@daveyholler daveyholler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saarikabhasi saarikabhasi merged commit e199282 into elastic:main Apr 27, 2023
@saarikabhasi saarikabhasi deleted the search-app-pageTemplate-cleanups branch April 27, 2023 17:47
@kibanamachine kibanamachine mentioned this pull request Apr 27, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 27, 2023
@saarikabhasi
[Search Application] Update pageTemplate header to grey and rename na…
20d52df 
…v item to "Search preview" (elastic#155795)

## Summary
* Rename nav item from "Preview" to "Search Preview"
* Update page Header to grey

### Screenshots

<img width="1728" alt="Search preview"
src="https://user-images.githubusercontent.com/55930906/234397633-003e4e99-680d-4531-8d94-528152fa2799.png">

<img width="1728" alt="Content"
src="https://user-images.githubusercontent.com/55930906/234397654-fb678a29-2c55-47d7-8d96-d8ce9f5164a2.png">

<img width="1728" alt="Connect"
src="https://user-images.githubusercontent.com/55930906/234397677-57823b14-16bf-44eb-9f01-eb6adca2a3fa.png">

(cherry picked from commit e199282)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 27, 2023
@kibanamachine @saarikabhasi
[8.8] [Search Application] Update pageTemplate header to grey and ren…
4ef2af3 
…ame nav item to "Search preview" (#155795) (#156071)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[Search Application] Update pageTemplate header to grey and rename
nav item to "Search preview"
(#155795)](#155795)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Saarika
Bhasi","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-04-27T17:46:22Z","message":"[Search
Application] Update pageTemplate header to grey and rename nav item to
\"Search preview\" (#155795)\n\n## Summary\r\n* Rename nav item from
\"Preview\" to \"Search Preview\"\r\n* Update page Header to
grey\r\n\r\n\r\n### Screenshots\r\n\r\n<img width=\"1728\" alt=\"Search
preview\"\r\nsrc=\"https://user-images.githubusercontent.com/55930906/234397633-003e4e99-680d-4531-8d94-528152fa2799.png\">\r\n\r\n<img
width=\"1728\"
alt=\"Content\"\r\nsrc=\"https://user-images.githubusercontent.com/55930906/234397654-fb678a29-2c55-47d7-8d96-d8ce9f5164a2.png\">\r\n\r\n<img
width=\"1728\"
alt=\"Connect\"\r\nsrc=\"https://user-images.githubusercontent.com/55930906/234397677-57823b14-16bf-44eb-9f01-eb6adca2a3fa.png\">","sha":"e199282adaa1dc25eec4ee53adb5bf052710814b","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.8.0","v8.9.0"],"number":155795,"url":"https://github.com/elastic/kibana/pull/155795","mergeCommit":{"message":"[Search
Application] Update pageTemplate header to grey and rename nav item to
\"Search preview\" (#155795)\n\n## Summary\r\n* Rename nav item from
\"Preview\" to \"Search Preview\"\r\n* Update page Header to
grey\r\n\r\n\r\n### Screenshots\r\n\r\n<img width=\"1728\" alt=\"Search
preview\"\r\nsrc=\"https://user-images.githubusercontent.com/55930906/234397633-003e4e99-680d-4531-8d94-528152fa2799.png\">\r\n\r\n<img
width=\"1728\"
alt=\"Content\"\r\nsrc=\"https://user-images.githubusercontent.com/55930906/234397654-fb678a29-2c55-47d7-8d96-d8ce9f5164a2.png\">\r\n\r\n<img
width=\"1728\"
alt=\"Connect\"\r\nsrc=\"https://user-images.githubusercontent.com/55930906/234397677-57823b14-16bf-44eb-9f01-eb6adca2a3fa.png\">","sha":"e199282adaa1dc25eec4ee53adb5bf052710814b"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155795","number":155795,"mergeCommit":{"message":"[Search
Application] Update pageTemplate header to grey and rename nav item to
\"Search preview\" (#155795)\n\n## Summary\r\n* Rename nav item from
\"Preview\" to \"Search Preview\"\r\n* Update page Header to
grey\r\n\r\n\r\n### Screenshots\r\n\r\n<img width=\"1728\" alt=\"Search
preview\"\r\nsrc=\"https://user-images.githubusercontent.com/55930906/234397633-003e4e99-680d-4531-8d94-528152fa2799.png\">\r\n\r\n<img
width=\"1728\"
alt=\"Content\"\r\nsrc=\"https://user-images.githubusercontent.com/55930906/234397654-fb678a29-2c55-47d7-8d96-d8ce9f5164a2.png\">\r\n\r\n<img
width=\"1728\"
alt=\"Connect\"\r\nsrc=\"https://user-images.githubusercontent.com/55930906/234397677-57823b14-16bf-44eb-9f01-eb6adca2a3fa.png\">","sha":"e199282adaa1dc25eec4ee53adb5bf052710814b"}}]}]
BACKPORT-->

Co-authored-by: Saarika Bhasi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sphilipse sphilipse sphilipse left review comments

@TattdCodeMonkey TattdCodeMonkey TattdCodeMonkey left review comments

@julianrosado julianrosado julianrosado approved these changes

@sloanelybutsurely sloanelybutsurely sloanelybutsurely approved these changes

@daveyholler daveyholler daveyholler approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.8.0 v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@saarikabhasi @kibana-ci @kibanamachine @daveyholler @sloanelybutsurely @TattdCodeMonkey @julianrosado @sphilipse