-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SecuritySolution] Replace dashboard listing with Kibana dashboard listing #155716
Closed
Closed
Changes from 22 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
cbeb700
replace dashboard listing
angorayc ff32ec5
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine 576ec4a
styling
angorayc 29f2a65
Merge branch 'dashboard-listing' of github.com:angorayc/kibana into d…
angorayc 2fbf9b8
add fixed tag
angorayc 7f33c9b
Merge remote-tracking branch 'upstream/main' into dashboard-listing
angorayc 6fa35ce
disable actions
angorayc 6b1d0b8
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine 6a5a791
types
angorayc a9a63a5
Merge branch 'dashboard-listing' of github.com:angorayc/kibana into d…
angorayc 6f04f3b
rm default value
angorayc 0f04412
rm default value
angorayc 205a5dc
Merge branch 'main' of github.com:elastic/kibana into dashboard-listing
angorayc 498ae01
update tags selection behaviour
angorayc f92bca0
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine c961de4
Merge branch 'main' of github.com:elastic/kibana into dashboard-listing
angorayc 55df917
Merge branch 'dashboard-listing' of github.com:angorayc/kibana into d…
angorayc fe9d202
unit tests
angorayc b743ea0
unit tests
angorayc eb0b111
fix selection
angorayc 47ca980
fix types
angorayc 770cfee
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine b797fc0
fix types
angorayc 23728b5
Merge branch 'dashboard-listing' of github.com:angorayc/kibana into d…
angorayc de5584b
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine 3bbac62
fix types
angorayc 9581c92
Merge branch 'dashboard-listing' of github.com:angorayc/kibana into d…
angorayc 3b84127
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we pass
options
and nottagSelection
? I would also pass an array iffixedTagReferences
is undefined or null to makegetTotalActiveFilters
simplerThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could really just be this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the tagSelection seemed to have problem displaying the actual count when a few tags sharing the same name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.