Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Exploratory View components from Observability #155629

Merged
merged 26 commits into from
Apr 26, 2023
Merged

Remove Exploratory View components from Observability #155629

merged 26 commits into from
Apr 26, 2023

Conversation

CoenWarmer
Copy link
Contributor

Resolves #153933

📝 Summary

Now that the Exploratory View route inside the Observability app has been copied into its own separate application (#153830), consuming applications use the components of this separate application (#154053, #154055), and users that are attempting to visit the Exploratory View route in Observability are redirected to the new URL (#153940), we can safely remove the Exploratory View component from the Observability app.

✅ Acceptance Criteria

  • All components related to rendering the Exploratory View component inside Observability should be removed from the Observability app
  • createExploratoryViewLink can be removed from Obs public plugin.ts

@CoenWarmer CoenWarmer requested review from a team as code owners April 24, 2023 14:21
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Apr 24, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@CoenWarmer CoenWarmer added the release_note:skip Skip the PR/issue when compiling release notes label Apr 24, 2023
@shahzad31 shahzad31 requested a review from a team as a code owner April 24, 2023 16:40
@shahzad31 shahzad31 removed the request for review from a team April 24, 2023 16:44
@shahzad31 shahzad31 requested a review from a team as a code owner April 24, 2023 17:44
jbudz
jbudz approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

limits.yml

shahzad31
shahzad31 approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uptime changes LGTM !!

@CoenWarmer CoenWarmer enabled auto-merge (squash) April 25, 2023 10:31
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 515 403 -112
observabilityShared 85 86 +1
total -111

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observability 650 552 -98
observabilityShared 32 142 +110
total +12

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
observability 44 43 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
exploratoryView 241.1KB 240.7KB -416.0B
observability 1.1MB 964.3KB -180.9KB
synthetics 1.2MB 1.2MB +2.0B
total -181.3KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
observability 33 24 -9

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
exploratoryView 60.7KB 60.5KB -200.0B
observability 74.7KB 55.7KB -19.0KB
observabilityShared 12.8KB 21.0KB +8.2KB
total -11.0KB
Unknown metric groups

API count

id before after diff
observability 656 558 -98
observabilityShared 32 142 +110
total +12

async chunk count

id before after diff
observability 19 14 -5

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
observability 46 33 -13
securitySolution 399 402 +3
total -8

References to deprecated APIs

id before after diff
observability 66 5 -61

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
observability 50 37 -13
securitySolution 479 482 +3
total -8

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@CoenWarmer CoenWarmer merged commit a07bdc5 into elastic:main Apr 26, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 26, 2023
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 26, 2023
@jloleysens
Merge branch 'main' into compatible-schema-change-check
ab5ff42 
* main: (1294 commits)
  [SecuritySolution] Refactor security packages (elastic#155365)
  [Discover] Show "Temporary" badge for ad-hoc data views in Alerts flyout (elastic#155717)
  [RAM] Conditional actions feedback on pr review (elastic#155804)
  [Files] Adds bulk delete method (elastic#155628)
  [Lens] Use proper way to generate absolute short URL (elastic#155512)
  [Guided onboarding] Use Kibana features to grant access (elastic#155065)
  [Index Management] Fix duped mock (elastic#155844)
  [Lens] Enhance visualization modifier popup with layer palette (elastic#155280)
  Fix flaky combobox tests on role management screen (elastic#155711)
  [Infrastructure UI] Create InventoryViewsService and InventoryViewsClient (elastic#155126)
  [Fleet] always create agent upload write indices (elastic#155729)
  [Fleet] [Cloud Security Posture] Add CloudFormation agent install method (elastic#155045)
  Add tech preview label for search applications (elastic#155649)
  [ML] AIOps: Stabilize flaky functional tests. (elastic#155710)
  [ES UI Shared] Migrate JsonEditor to monaco (elastic#155610)
  [Security Solution] Fixes security_solution storybooks always rendering in a flyout (elastic#155814)
  [Synthetics] Make error popover disappear `onMouseLeave` of metric item card (elastic#155800)
  Remove Exploratory View components from Observability (elastic#155629)
  [Discover] Remove redundant "Filter was added" toast (elastic#155645)
  [RAM][Security Solution][Alerts] Support the ability to trigger a rule action per alert generated (elastic#153611) (elastic#155384)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzad31 shahzad31 shahzad31 approved these changes

@jbudz jbudz jbudz approved these changes

@benakansara benakansara benakansara approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Observability] Remove Exploratory View components from Observability app
8 participants
@CoenWarmer @elasticmachine @apmmachine @kibana-ci @jbudz @shahzad31 @benakansara @kibanamachine