Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade EUI to v77.2.2 #155208

Merged
merged 16 commits into from
May 5, 2023
Merged

Upgrade EUI to v77.2.2 #155208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
978f428
Bumping EUI to v77.2.0.
1Copenut Apr 18, 2023
70cf830
Adding language translations for EUI v77.2.0 bump.
1Copenut Apr 18, 2023
a2ab2aa
Updating snapshot tests for EUI.
1Copenut Apr 19, 2023
5e8010b
Updating unit test for new EuiDatePickerRange JSX structure.
1Copenut Apr 20, 2023
526edd4
Revising one test from mount to shallow Enzyme method.
1Copenut Apr 20, 2023
899b5d3
Fixing CSS in query string text area.
1Copenut Apr 25, 2023
a708c48
Backport EUI v77.2.1
cee-chen Apr 27, 2023
142d398
Merge branch 'main' into feature/eui-v77.2.0
kibanamachine Apr 27, 2023
7c6c1e7
Merge branch 'main' into feature/eui-v77.2.0
kibanamachine Apr 28, 2023
0a6f436
Merge branch 'main' into feature/eui-v77.2.0
1Copenut Apr 28, 2023
3355336
Bumping EUI to 72.2.2 backport.
1Copenut May 1, 2023
966e65b
Merging upstream main.
1Copenut May 1, 2023
186be51
package.json newline.
1Copenut May 1, 2023
2ded4cf
Fix maps location decimal degrees showing invalid state for decimal s…
cee-chen May 1, 2023
ba76636
Harden maps FTR tests
cee-chen May 1, 2023
3e80248
Merge branch 'main' into feature/eui-v77.2.0
cee-chen May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
"@elastic/datemath": "5.0.3",
"@elastic/elasticsearch": "npm:@elastic/[email protected]",
"@elastic/ems-client": "8.4.0",
"@elastic/eui": "77.1.2",
"@elastic/eui": "77.2.2",
"@elastic/filesaver": "1.1.2",
"@elastic/node-crypto": "1.2.1",
"@elastic/numeral": "^2.5.1",
Expand Down
1 change: 1 addition & 0 deletions packages/core/i18n/core-i18n-browser-internal/src/__snapshots__/i18n_service.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions packages/core/i18n/core-i18n-browser-internal/src/i18n_eui_mapping.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,6 +778,12 @@ export const getEuiContextMapping = (): EuiTokensObject => {
description: 'ARIA label on a button that removes any entry in a form field',
}
),
'euiFormControlLayoutDelimited.delimiterLabel': i18n.translate(
'core.euiFormControlLayoutDelimited.delimiterLabel',
{
defaultMessage: 'to',
}
),
'euiFullscreenSelector.fullscreenButton': i18n.translate(
'core.euiFullscreenSelector.fullscreenButton',
{
Expand Down
16 changes: 8 additions & 8 deletions ...s/kbn-securitysolution-autocomplete/src/field/__tests__/__snapshots__/index.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion ...olution-exception-list-components/src/list_header/__snapshots__/list_header.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion ...ception-list-components/src/list_header/edit_modal/__snapshots__/edit_modal.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/dev/license_checker/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,6 @@ export const LICENSE_OVERRIDES = {
'[email protected]': ['Eclipse Distribution License - v 1.0'], // cf. https://github.com/bjornharrtell/jsts
'@mapbox/[email protected]': ['MIT'], // license in readme https://github.com/tmcw/jsonlint
'@elastic/[email protected]': ['Elastic License 2.0'],
'@elastic/eui@77.1.2': ['SSPL-1.0 OR Elastic License 2.0'],
'@elastic/eui@77.2.2': ['SSPL-1.0 OR Elastic License 2.0'],
'[email protected]': ['CC-BY-4.0'], // retired ODC‑By license https://github.com/mattcg/language-subtag-registry
};
2 changes: 1 addition & 1 deletion ..._editor/public/components/field_format_editor/editors/url/__snapshots__/url.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

38 changes: 19 additions & 19 deletions ...lugins/es_ui_shared/public/components/cron_editor/__snapshots__/cron_editor.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion src/plugins/unified_search/public/query_string_input/query_string_input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -832,8 +832,9 @@ export default class QueryStringInputUI extends PureComponent<QueryStringInputPr
>
{this.forwardNewValueIfNeeded(this.getQueryString())}
</EuiTextArea>
{/* EUI TODO: This will need to be fixed before the Emotion conversion */}
Copy link
Contributor

@stratoula stratoula May 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cee-chen @1Copenut what is it about? What needs to be fixed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component is our EUI Sass-generated classNames directly instead of EUI components (i.e., className="euiFormControlLayoutIcons" vs. <EuiFormControlLayout>).

In general, we strongly advise against this usage of EUI - but specifically, once our form components are converted to Emotion, said classNames will no longer have any meaningful CSS attached to them and the visual appearance of this icon will break again.

Part of why this custom implementation was added was (I assume) because EuiTextArea doesn't implement icon support OOTB - that's either something we can look at on EUI's end, or we can try to tweak this plugin in Kibana to use EUI components instead of classes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it! So for now we are ok, we will revisit when we convert the component to use emotion instead 👍

{this.props.iconType ? (
<div className="euiFormControlLayoutIcons">
<div className="euiFormControlLayoutIcons euiFormControlLayoutIcons--absolute euiFormControlLayoutIcons--left">
<EuiIcon
className="euiFormControlLayoutCustomIcon__icon"
aria-hidden="true"
Expand Down
1 change: 0 additions & 1 deletion .../canvas/shareable_runtime/components/footer/settings/__snapshots__/settings.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading