[Files] Allow option to disable delete action in mgt UI

[sebelga]

This PR adds the possibility to disable behaviour of files in the Files management UI. It is now possible to disable

• list - Files won't show in the management UI
• delete - It won't be possible to delete the file from the management UI

Option added to the public registry: managementUiActions

files.registerFileKind({
      id: "...",
      allowedMimeTypes: "...",
      managementUiActions: { // NEW
        list: {
          enabled: false,
        },
        // If "list" is not enabled, this is not necessary :)
        // I leave it for documentation purpose
        delete: {
          enabled: false,
          reason: "Explain why the file cannot be deleted", // optional but nice for our users
        }
      },
    });

How to test

• run kibana with the examples yarn start --run-examples
• open the "Files" example an upload a file in each table (all UI actions, no listing and no delete action)
• Navigate to the Management > Kibana > Files page and verify that the corresponding files are not shown or can't be deleted

Screenshots

Fixes #153756

[elasticmachine]

Pinging @elastic/appex-sharedux (Team:SharedUX)

[jonathan-buttner]

Thanks for the changes! The functionality provided in these changes looks good to me! I pulled your branch and made the modifications to cases and the cases files no longer show in the file management UI 👍

I also tested that users can't delete through the file management UI when the files are listed

[sebelga]

Thanks for the review @jonathan-buttner ! 👍

[Dosant]

I am not sure what's wrong exactly, but files management doesn't seem to be working properly for me:

So I have a file that can't be deleted and two files that can. When I try to select files that can be deleted the selection state isn't correct and the delete button count / modal also doesn't reflect my selection:

delete.bug.mov

[sebelga]

Thanks for the review @Dosant !

I am not sure what's wrong exactly, but files management doesn't seem to be working properly for me

Great catch. There was a memoization issue creating the state to be reinitialized on every render. I fixed it in fcd224c

Can you have another look?

[kibana-ci]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: ab61545

Failed CI Steps

• FTR Configs #37

Test Failures

• [job] [logs] FTR Configs #37 / discover/group3 discover sidebar renders field groups should work when filters change

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
@kbn/content-management-table-list	13	14	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
dashboard	433.8KB	434.5KB	+706.0B
filesManagement	86.2KB	87.6KB	+1.4KB
graph	453.2KB	453.9KB	+709.0B
maps	2.8MB	2.8MB	+709.0B
visualizations	259.5KB	260.2KB	+712.0B
total			+4.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
files	10.5KB	10.6KB	+99.0B

Unknown metric groups

API count

id	before	after	diff
@kbn/content-management-table-list	20	21	+1
@kbn/shared-ux-file-types	70	71	+1
files	215	217	+2
total			+4

ESLint disabled line counts

id	before	after	diff
enterpriseSearch	17	19	+2
securitySolution	395	398	+3
total			+5

Total ESLint disabled count

id	before	after	diff
enterpriseSearch	18	20	+2
securitySolution	475	478	+3
total			+5

History

• 💚 Build #121910 succeeded 00dfc01
• 💚 Build #121668 succeeded cb15612
• 💛 Build #121500 was flaky 52b5b5f
• 💔 Build #121250 failed 734f41bf054d74d984e744fefa3a97e9acb3e54d
• 💚 Build #121164 succeeded 9a08da057d78fbe66529e5a0201aa4a3703552d8
• 💚 Build #120789 succeeded ea72db41c25cd69f20a97c953e580d39fcd6eabf

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sebelga

[Dosant]

Thanks for the changes! re-tested. looks good