-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EUI: Reset CSS #15486
Closed
Closed
EUI: Reset CSS #15486
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
37a5731
Autoload eui_theme_light.css.
cjcenizal 4903b95
Remove naked element selectors from base.less.
cjcenizal cb4dd16
Remove Bootstrap resets.
cjcenizal 445c4cb
Remove UI Framework reset.
cjcenizal 4736b6f
Remove unused reset styles from UI Framework.
cjcenizal ba8c345
Replace usage of sr-only with euiScreenReaderOnly.
cjcenizal 6df7ec0
Apply euiButtonEmpty classes to the 'Add a filter' button.
cjcenizal d67192f
Fix Notification padding and layout.
cjcenizal cf5c6a2
Apply euiTabs styles to Timepicker mode tabs.
cjcenizal c88650e
Fix layout of Available Fields heading in Discover.
cjcenizal 4e50801
Add padding to Popular Fields container in Discover.
cjcenizal c57df5b
Push down Selected Fields heading in Discover sidebar.
cjcenizal db9408d
Fix appearance of links in Discover sidebar.
cjcenizal 01e5f66
Fix height of pills in Filter Bar.
cjcenizal 180d2a4
Add support for using dark theme EUI CSS in Dashboard.
cjcenizal 11f27ac
Remove commented-out CSS import.
cjcenizal f68781f
Set light theme as the default.
cjcenizal 700017d
Fix bug with style-loader by using raw-loader and innerHTML to set th…
cjcenizal 032368c
Remove commented-out code.
cjcenizal 41bf847
Add comments to chrome.jade about role of theme node.
cjcenizal 6bb72a5
Add XSS note to themes.js.
cjcenizal 6bca9e9
EUI css reset fixes
snide acb6de0
Add EUI v0.0.5 as a dependency.
cjcenizal 536e5a9
Label fix for EUI regression (#15605)
snide ecba3f8
Upgrade to EUI v0.0.6. Fix linting errors.
cjcenizal a3ce294
Add (WTFPL OR MIT) to acceptable licenses.
cjcenizal 8c43cf4
Use cssText instead of innerHTML to set theme styles.
cjcenizal f91b40e
Set dark theme CSS string instead of an array containing the string.
cjcenizal aa6b14d
Fix linting error.
cjcenizal 464ebc7
Remove kbn-accessible-click from timepicker buttons.
cjcenizal 8fd6a73
Fix tests for timepicker.
cjcenizal e132de4
Fix tests for timepicker... again.
cjcenizal 5c2751c
Set quiet temporarily to false.
cjcenizal f728530
Experiment: downgrade to 0.0.5 to see if tests pass.
cjcenizal 407fd24
Experiment: downgrade to 0.0.3 to see if tests pass.
cjcenizal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,40 +1,38 @@ | ||
| <h2 class="kuiLocalDropdownTitle">Help</h2> | ||
| <h2 class="euiTitle">Help</h2> | ||
|
|
||
| <tabset> | ||
| <tab heading="Request format"> | ||
| <div class="list-group-item list-group-item--noBorder"> | ||
| <div class="euiSpacer euiSpacer--m"></div> | ||
|
|
||
| <div class="euiPanel euiPanel--paddingLarge"> | ||
| <div class="euiFlexGroup euiFlexGroup--gutterExtraLarge"> | ||
| <div class="euiFlexItem"> | ||
| <h2 class="euiTitle">Request format</h2> | ||
| <div class="euiSpacer euiSpacer--l"></div> | ||
| You can type one or more requests in the white editor. Console understands requests in a compact format: | ||
| <sense-help-example></sense-help-example> | ||
| </div> | ||
| </tab> | ||
| <tab heading="Keyboard tips"> | ||
| <div class="list-group-item list-group-item--noBorder"> | ||
| <dl class="dl-horizontal"> | ||
| <dt></dt> | ||
| <dd><strong>General editing</strong></dd> | ||
| <dt>Ctrl/Cmd + I</dt> | ||
| <dd>Auto indent current request</dd> | ||
| <dt>Ctrl + Space</dt> | ||
| <dd>Open Auto complete (even if not typing)</dd> | ||
| <dt>Ctrl/Cmd + Enter</dt> | ||
| <dd>Submit request</dd> | ||
| <dt>Ctrl/Cmd + Up/Down</dt> | ||
| <dd>Jump to the previous/next request start or end.</dd> | ||
| <dt>Ctrl/Cmd + Alt + L</dt> | ||
| <dd>Collapse/expand current scope.</dd> | ||
| <dt>Ctrl/Cmd + Option + 0</dt> | ||
| <dd>Collapse all scopes but the current one. Expand by adding a shift.</dd> | ||
| </dl> | ||
| <dl class="dl-horizontal"> | ||
| <dt></dt> | ||
| <dd><strong>When auto-complete is visible</strong></dd> | ||
| <dt>Down arrow</dt> | ||
| <dd>Switch focus to auto-complete menu. Use arrows to further select a term</dd> | ||
| <dt>Enter/Tab</dt> | ||
| <dd>Select the currently selected or the top most term in auto-complete menu</dd> | ||
| <dt>Esc</dt> | ||
| <dd>Close auto-complete menu</dd> | ||
| <div class="euiFlexItem"> | ||
| <h2 class="euiTitle">Keyboard commands</h2> | ||
| <div class="euiSpacer euiSpacer--l"></div> | ||
| <dl class="euiDescriptionList euiDescriptionList--row euiDescriptionList--compressed"> | ||
| <dt class="euiDescriptionList__title">Ctrl/Cmd + I</dt> | ||
| <dd class="euiDescriptionList__description">Auto indent current request</dd> | ||
| <dt class="euiDescriptionList__title">Ctrl + Space</dt> | ||
| <dd class="euiDescriptionList__description">Open Auto complete (even if not typing)</dd> | ||
| <dt class="euiDescriptionList__title">Ctrl/Cmd + Enter</dt> | ||
| <dd class="euiDescriptionList__description">Submit request</dd> | ||
| <dt class="euiDescriptionList__title">Ctrl/Cmd + Up/Down</dt> | ||
| <dd class="euiDescriptionList__description">Jump to the previous/next request start or end.</dd> | ||
| <dt class="euiDescriptionList__title">Ctrl/Cmd + Alt + L</dt> | ||
| <dd class="euiDescriptionList__description">Collapse/expand current scope.</dd> | ||
| <dt class="euiDescriptionList__title">Ctrl/Cmd + Option + 0</dt> | ||
| <dd class="euiDescriptionList__description">Collapse all scopes but the current one. Expand by adding a shift.</dd> | ||
| <dt class="euiDescriptionList__title">Down arrow</dt> | ||
| <dd class="euiDescriptionList__description">Switch focus to auto-complete menu. Use arrows to further select a term</dd> | ||
| <dt class="euiDescriptionList__title">Enter/Tab</dt> | ||
| <dd class="euiDescriptionList__description">Select the currently selected or the top most term in auto-complete menu</dd> | ||
| <dt class="euiDescriptionList__title">Esc</dt> | ||
| <dd class="euiDescriptionList__description">Close auto-complete menu</dd> | ||
| </dl> | ||
| </div> | ||
| </tab> | ||
| </tabset> | ||
| </div> | ||
| </div> |
70 changes: 37 additions & 33 deletions
70
src/core_plugins/console/public/src/directives/welcome.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,37 @@ | ||
| <h2 class="kuiLocalDropdownTitle">Welcome to Console</h2> | ||
|
|
||
| <p><strong>Quick intro to the UI</strong></p> | ||
|
|
||
| <p>The Console UI is split into two panes: an editor pane (left) and a response pane (right). | ||
| Use the editor to type requests and submit them to Elasticsearch. The results will be displayed in | ||
| the response pane on the right side. | ||
| </p> | ||
|
|
||
| <p>Console understands requests in a compact format, similar to cURL: | ||
| <sense-help-example></sense-help-example> | ||
|
|
||
| <p>While typing a request, Console will make suggestions which you can then accept by hitting Enter/Tab. | ||
| These suggestions are made based on the request structure <i>as well as</i> your indices and types. | ||
| </p> | ||
|
|
||
| <p><strong>A few quick tips, while I have your attention</strong></p> | ||
| <ul> | ||
| <li>Submit requests to ES using the green triangle button.</li> | ||
| <li>Use the wrench menu for other useful things.</li> | ||
| <li>You can paste requests in cURL format and they will be translated to the Console syntax.</li> | ||
| <li>You can resize the editor and output panes by dragging the separator between them.</li> | ||
| <li>Study the keyboard shortcuts under the Help button. Good stuff in there!</li> | ||
| </ul> | ||
|
|
||
| <button | ||
| type="button" | ||
| class="kuiButton kuiButton--primary" | ||
| data-test-subj="help-close-button" | ||
| ng-click="kbnTopNav.close()" | ||
| > | ||
| Get to work | ||
| </button> | ||
| <div class="euiText"> | ||
|
|
||
| <h2>Welcome to Console</h2> | ||
|
|
||
| <p><strong>Quick intro to the UI</strong></p> | ||
|
|
||
| <p>The Console UI is split into two panes: an editor pane (left) and a response pane (right). | ||
| Use the editor to type requests and submit them to Elasticsearch. The results will be displayed in | ||
| the response pane on the right side. | ||
| </p> | ||
|
|
||
| <p>Console understands requests in a compact format, similar to cURL: | ||
| <sense-help-example></sense-help-example> | ||
|
|
||
| <p>While typing a request, Console will make suggestions which you can then accept by hitting Enter/Tab. | ||
| These suggestions are made based on the request structure <i>as well as</i> your indices and types. | ||
| </p> | ||
|
|
||
| <p><strong>A few quick tips, while I have your attention</strong></p> | ||
| <ul> | ||
| <li>Submit requests to ES using the green triangle button.</li> | ||
| <li>Use the wrench menu for other useful things.</li> | ||
| <li>You can paste requests in cURL format and they will be translated to the Console syntax.</li> | ||
| <li>You can resize the editor and output panes by dragging the separator between them.</li> | ||
| <li>Study the keyboard shortcuts under the Help button. Good stuff in there!</li> | ||
| </ul> | ||
|
|
||
| <button | ||
| type="button" | ||
| class="kuiButton kuiButton--primary" | ||
| data-test-subj="help-close-button" | ||
| ng-click="kbnTopNav.close()" | ||
| > | ||
| Get to work | ||
| </button> | ||
|
|
||
| </div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing this is still needed because dashboard is a combination of non-eui elements and eui elements, so for the time being we keep both dark theme applications around?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. KUI and EUI will live side-by-side as we gradually convert our UI to depend upon EUI.