feat(slo): Add more tooltip in burn rate rule #154840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdelemme
added
release_note:skip
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
CoenWarmer
reviewed
Apr 12, 2023
| <EuiSpacer size="m" /> | ||
| </EuiFlexGroup> | ||
| ); | ||
| } | ||
|
|
||
| const getErrorBudgetExhaustionText = (formatedHours: string) => | ||
| i18n.translate('xpack.observability.slo.rules.errorBudgetExhaustion.text', { | ||
| defaultMessage: | ||
| "At this rate, the SLO's error budget will be exhausted after {formatedHours} hours.", | ||
| defaultMessage: '{formatedHours} hours until error budget exhaustion.', |
There was a problem hiding this comment.
Suggested change
| defaultMessage: '{formatedHours} hours until error budget exhaustion.', | |
| defaultMessage: '{formattedHours} hours until error budget exhaustion.', |
CoenWarmer
reviewed
Apr 12, 2023
| {getErrorBudgetExhaustionText(computeErrorBudgetExhaustionInHours())} | ||
| </EuiText> | ||
| </EuiFlexItem> | ||
| </EuiFlexGroup> | ||
| <EuiSpacer size="m" /> | ||
| </EuiFlexGroup> | ||
| ); | ||
| } | ||
|
|
||
| const getErrorBudgetExhaustionText = (formatedHours: string) => |
There was a problem hiding this comment.
Suggested change
| const getErrorBudgetExhaustionText = (formatedHours: string) => | |
| const getErrorBudgetExhaustionText = (formattedHours: string) => |
There was a problem hiding this comment.
very nitty, apologies 😬
CoenWarmer
approved these changes
Apr 12, 2023
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @kdelemme |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #154839
Adds tooltips in burn rate rule. Move explanations into helpText under burn rate threshold input.