-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throttle toast storms related to saving/restoring URL state #154792
Conversation
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
Pinging @elastic/kibana-presentation (Team:Presentation) |
💚 Build Succeeded
Metrics [docs]Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @lukasolson |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good and work as expected - however, it would be nice to reduce this to a single toast.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Toast storms while reviewing this PR:
@mattkime agreed, just one would be even better, could be a potential follow up (those toast a thrown at 2 different parts of our code, one way to deal with it could be throwing a custom error, and don't use this error to start a toast at one of code locations)
Summary
Resolves #153073.
Throttles toast errors related to restoring/saving URL state.
Before:
After:
Checklist