Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Observability Page Template from Observability Shared in Infra #154778

Conversation

CoenWarmer
Copy link
Contributor

@CoenWarmer CoenWarmer commented Apr 11, 2023

Resolves #154777

📝 Summary

As part of #154735 a Observability Shared app was created, which exports the Observability Page Template.

This PR updates the Infra app to use the Observability Page Template from Observability Shared.

More details about the change in the PR linked above. Summarized, this change comes down to:

Untitled (3)

✅ Checklist

  • All links and navigation should behave exactly as before.

@CoenWarmer CoenWarmer requested a review from a team as a code owner April 11, 2023 20:28
@CoenWarmer CoenWarmer added the release_note:skip Skip the PR/issue when compiling release notes label Apr 11, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@CoenWarmer CoenWarmer force-pushed the chore/use-observability-page-template-from-observability-shared-in-infra branch from d5b2eb9 to ef15de5 Compare April 11, 2023 21:24
@CoenWarmer CoenWarmer enabled auto-merge (squash) April 12, 2023 08:57
@CoenWarmer CoenWarmer added the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label Apr 13, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

Copy link
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for applying the change!

@CoenWarmer CoenWarmer force-pushed the chore/use-observability-page-template-from-observability-shared-in-infra branch from 391f8d6 to 2b020a7 Compare April 17, 2023 10:53
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 2.0MB 2.0MB +24.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
infra 90.0KB 90.0KB +6.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 432 435 +3

Total ESLint disabled count

id before after diff
securitySolution 512 515 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@CoenWarmer CoenWarmer merged commit 5464614 into elastic:main Apr 17, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Observability Page Template from Observability Shared in Infra
6 participants