Use Observability Page Template from Observability Shared in APM and Profiling #154776
Conversation
|
Pinging @elastic/apm-ui (Team:APM) |
CoenWarmer
added
the
release_note:skip
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
CoenWarmer
force-pushed
the
chore/use-observability-page-template-from-observability-shared-in-apm-and-profiling
branch
from
006257d to
eea33ef
Compare
|
@elasticmachine merge upstream |
…bservability-shared-in-apm-and-profiling
|
@elasticmachine merge upstream |
…bservability-shared-in-apm-and-profiling
|
@elasticmachine merge upstream |
…bservability-shared-in-apm-and-profiling
|
@elasticmachine merge upstream |
…bservability-shared-in-apm-and-profiling
| "observability", | ||
| "observabilityShared", |
There was a problem hiding this comment.
What's the difference between observability and observability_shared? By reading each README file looks like they exist for the same purpose.
There was a problem hiding this comment.
There's two primary reasons for this change, one conceptual and one practical.
- When the Observability app started, it was just the Overview page. It made sense to use it as a sharing place for all downstream Observability apps. Over time a lot more routes have been added: we are now at 9 routes and counting. There is so much dedicated logic inside the app that it starts to make less sense to keep it as a shared repository dictating how the other apps should work. I believe it should more be like a downstream app that consumes shared resources like all the other Observability apps do.
- The Synthetics team has placed a component in the Observability app which requires the Exploratory View app. But the Exploratory View app requires the Observability app as it shares the same navigation. This creates a circular dependency. This change enables that both the Observability app and Exploratory View can share the same page template, and that the Observability app can require the Exploratory View app so it can render the Synthetics widget.
There was a problem hiding this comment.
Does the Observability plugin also depend on the Observability_shared plugin? Or can it? Is there a plan to "clean up" the observability plugin by moving stuff that is actually shared to the new plugin?
There was a problem hiding this comment.
Does the Observability plugin also depend on the Observability_shared plugin?
Yes, or at least, it will in an upcoming PR.
Is there a plan to "clean up" the observability plugin by moving stuff that is actually shared to the new plugin?
Yes, I intend to kick out all shared stuff to Observability_shared.
…bservability-shared-in-apm-and-profiling
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
|
/oblt-deploy |
Resolves #154775
📝 Summary
As part of #154716 a Observability Shared app was created, which exports the Observability Page Template.
This PR updates the APM and Profiling apps to use the Observability Page Template from Observability Shared.
More details about the change in the PR linked above. Summarized, this change comes down to:
✅ Checklist