Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Observability Page Template from Observability Shared #154774

Conversation

CoenWarmer
Copy link
Contributor

@CoenWarmer CoenWarmer commented Apr 11, 2023

Resolves #154773
Resolves #154779

📝 Summary

As part of #154735 a Observability Shared app was created, which exports the Observability Page Template.

This PR updates the Observability, Ux, Synthetics and Uptime apps to use the Observability Page Template from Observability Shared.

More details about the change in the PR linked above. Summarized, this change comes down to:

Untitled (3)

✅ Checklist

  • All links and navigation should behave exactly as before.

@CoenWarmer CoenWarmer requested a review from a team as a code owner April 11, 2023 20:07
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Apr 11, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@CoenWarmer CoenWarmer added the release_note:skip Skip the PR/issue when compiling release notes label Apr 11, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@CoenWarmer
Copy link
Contributor Author

@elasticmachine merge upstream

@CoenWarmer CoenWarmer changed the title Use Observability Page Template from Observability Shared [Synthetics][Ux][Uptime] Use Observability Page Template from Observability Shared Apr 11, 2023
@CoenWarmer CoenWarmer force-pushed the chore/use-observability-page-template-from-observability-shared branch from 9a3ec6e to aaeca79 Compare April 12, 2023 08:13
@CoenWarmer
Copy link
Contributor Author

@elasticmachine merge upstream

@CoenWarmer
Copy link
Contributor Author

@elasticmachine merge upstream

@CoenWarmer
Copy link
Contributor Author

@elasticmachine merge upstream

@CoenWarmer
Copy link
Contributor Author

@elasticmachine merge upstream

@CoenWarmer CoenWarmer enabled auto-merge (squash) April 18, 2023 11:19
@CoenWarmer
Copy link
Contributor Author

@elasticmachine merge upstream

@CoenWarmer CoenWarmer requested a review from a team as a code owner April 18, 2023 12:06
@CoenWarmer CoenWarmer changed the title [Synthetics][Ux][Uptime] Use Observability Page Template from Observability Shared Use Observability Page Template from Observability Shared Apr 18, 2023
@CoenWarmer CoenWarmer force-pushed the chore/use-observability-page-template-from-observability-shared branch from 28d9ad4 to 22e56a6 Compare April 18, 2023 12:13
@CoenWarmer CoenWarmer force-pushed the chore/use-observability-page-template-from-observability-shared branch 4 times, most recently from ae3e51a to 9a4e49f Compare April 18, 2023 13:48
Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CoenWarmer CoenWarmer force-pushed the chore/use-observability-page-template-from-observability-shared branch from fe3c2bc to 74d2dd6 Compare April 18, 2023 15:11
@CoenWarmer CoenWarmer requested a review from a team as a code owner April 18, 2023 15:11
@CoenWarmer CoenWarmer force-pushed the chore/use-observability-page-template-from-observability-shared branch from 7954ef3 to 94d5523 Compare April 18, 2023 17:03
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 515 512 -3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
exploratoryView 349 348 -1
observability 647 650 +3
observabilityShared 30 32 +2
total +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
exploratoryView 242.6KB 241.1KB -1.4KB
observability 1.1MB 1.1MB +7.9KB
observabilityShared 37.3KB 30.9KB -6.4KB
profiling 280.5KB 280.5KB +12.0B
synthetics 1.2MB 1.2MB +98.0B
ux 161.0KB 161.1KB +50.0B
total +236.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
observability 34 33 -1
observabilityShared 4 5 +1
total -0

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
exploratoryView 59.6KB 60.6KB +976.0B
observability 89.2KB 74.3KB -14.9KB
observabilityShared 6.0KB 12.8KB +6.8KB
synthetics 27.0KB 27.0KB +6.0B
ux 6.3KB 6.3KB +6.0B
total -7.1KB
Unknown metric groups

API count

id before after diff
exploratoryView 352 351 -1
observability 653 656 +3
observabilityShared 30 32 +2
total +4

async chunk count

id before after diff
observability 17 19 +2

ESLint disabled line counts

id before after diff
observabilityShared 1 3 +2
securitySolution 432 435 +3
total +5

Total ESLint disabled count

id before after diff
observabilityShared 1 3 +2
securitySolution 512 515 +3
total +5

History

  • 💔 Build #120765 failed 7954ef3dbb820197ae6dcaa651b22c691620de1f
  • 💔 Build #120721 failed fe3c2bc5c165631f904f29a9188215760bb502aa
  • 💔 Build #120704 failed ae3e51ad47bab24a5bcfa75dca8534ee9e1085af
  • 💔 Build #120677 failed 101d29028b192dd3190226d04c44d51044144a18
  • 💔 Build #120663 failed 1ae94ac65e85a7b8ee549bfe9d31daccc7011f5b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@jbcrail jbcrail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@CoenWarmer CoenWarmer merged commit 88f4f80 into elastic:main Apr 18, 2023
@kibanamachine kibanamachine added v8.8.0 backport:skip This commit does not require backporting labels Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.8.0
Projects
None yet
8 participants