[Dashboard] Fix unsaved changes badge React error #154607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heenawter
added
bug
Heenawter
force-pushed
the
fix-unsaved-badge-react-error_2023-04-06
branch
from
786dfe0
to
080b8b8
Compare
Heenawter
force-pushed
the
fix-unsaved-badge-react-error_2023-04-06
branch
2 times, most recently
from
6587e47
to
a1d84bb
Compare
Heenawter
force-pushed
the
fix-unsaved-badge-react-error_2023-04-06
branch
from
a1d84bb
to
7bd06a1
Compare
💚 Build Succeeded
Metrics [docs]Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
nickpeihl
approved these changes
Apr 11, 2023
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
kibanamachine
added
v8.8.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before
Since adding the tooltip to the unsaved changes badge in #154253, React was throwing an error to the console because the element in the top nav no longer had a unique key:
Screen.Recording.2023-04-10.at.8.57.26.AM.mov
After
This PR fixes this by adding the key to the tooltip if the badge has one; if it doesn't have a tooltip, then the key is added directly to the
EuiBadgeas expected. It also ensures that the tooltip has the proper a11y support (cc @elastic/kibana-accessibility) by adding the badge to the tab order and using the pass-through-props to ensure that the tooltip shows up on focus:Screen.Recording.2023-04-10.at.9.07.04.AM.mov
Checklist
For maintainers