-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] add session view component to expandable flyout #154597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeOberti
added
release_note:feature
Makes this part of the condensed release notes
Team:Threat Hunting:Investigations
Security Solution Investigations Team
v8.8.0
labels
Apr 6, 2023
PhilippeOberti
force-pushed
the
expanded-flyout-6103
branch
3 times, most recently
from
April 10, 2023 03:44
d092561
to
8956116
Compare
x-pack/plugins/security_solution/public/flyout/left/components/session_view.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/flyout/left/components/session_view.test.tsx
Show resolved
Hide resolved
PhilippeOberti
force-pushed
the
expanded-flyout-6103
branch
2 times, most recently
from
April 17, 2023 17:12
ea235cf
to
a784549
Compare
PhilippeOberti
force-pushed
the
expanded-flyout-6103
branch
from
April 17, 2023 20:38
a784549
to
c536235
Compare
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
christineweng
approved these changes
Apr 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:feature
Makes this part of the condensed release notes
Team:Threat Hunting:Investigations
Security Solution Investigations Team
v8.8.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the session view component to the expandable flyout left section, under the Session View tab under the Visualize tab.
Currently, the new code reuses the existing session view component without making any UI changes.
Notes
How to test
xpack.securitySolution.enableExperimental: ['securityFlyoutEnabled']
to thekibana.json
fileyarn es snapshot --license trial
,yarn test:generate
andyarn start --no-base-path
Run tests and storybook
node scripts/storybook security_solution
to run Storybooknpm run test:jest --config ./x-pack/plugins/security_solution/public/flyout
to run the unit testsyarn cypress:open-as-ci
but note that the integration/e2e tests have been written but are now skipped because the feature is protected behind a feature flag, disabled by default. To check them, add'securityFlyoutEnabled'
hereNo data
Screen.Recording.2023-04-06.at.2.16.20.PM.mov
With session view data
Screen.Recording.2023-04-06.at.2.12.23.PM.mov
https://github.com/elastic/security-team/issues/6103
Checklist
Delete any items that are not applicable to this PR.