Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] add session view component to expandable flyout #154597

Merged
merged 3 commits into from
Apr 21, 2023

Conversation

PhilippeOberti
Copy link
Contributor

@PhilippeOberti PhilippeOberti commented Apr 6, 2023

Summary

This PR adds the session view component to the expandable flyout left section, under the Session View tab under the Visualize tab.
Currently, the new code reuses the existing session view component without making any UI changes.

Notes

  • the UI is not following the mocks at the moment, it will be improved in future PRs
  • the e2e aren't covering much, as the fake data isn't setup to display the session view component

How to test

  • add xpack.securitySolution.enableExperimental: ['securityFlyoutEnabled'] to the kibana.json file
  • run yarn es snapshot --license trial, yarn test:generate and yarn start --no-base-path
  • go to the Alerts page, and click on the expand detail button on any row of the table
  • navigate to the Overview tab

Run tests and storybook

  • node scripts/storybook security_solution to run Storybook
  • npm run test:jest --config ./x-pack/plugins/security_solution/public/flyout to run the unit tests
  • yarn cypress:open-as-ci but note that the integration/e2e tests have been written but are now skipped because the feature is protected behind a feature flag, disabled by default. To check them, add 'securityFlyoutEnabled' here

No data

Screen.Recording.2023-04-06.at.2.16.20.PM.mov

With session view data

Screen.Recording.2023-04-06.at.2.12.23.PM.mov

https://github.com/elastic/security-team/issues/6103

Checklist

Delete any items that are not applicable to this PR.

@PhilippeOberti PhilippeOberti requested review from a team as code owners April 6, 2023 19:38
@PhilippeOberti PhilippeOberti added release_note:feature Makes this part of the condensed release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.8.0 labels Apr 6, 2023
@PhilippeOberti PhilippeOberti force-pushed the expanded-flyout-6103 branch 3 times, most recently from d092561 to 8956116 Compare April 10, 2023 03:44
@PhilippeOberti PhilippeOberti force-pushed the expanded-flyout-6103 branch 2 times, most recently from ea235cf to a784549 Compare April 17, 2023 17:12
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 15.9MB 15.9MB +5.6KB
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 432 435 +3

Total ESLint disabled count

id before after diff
securitySolution 512 515 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@christineweng christineweng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@PhilippeOberti PhilippeOberti merged commit ec6bc2d into main Apr 21, 2023
@PhilippeOberti PhilippeOberti deleted the expanded-flyout-6103 branch April 21, 2023 19:19
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:feature Makes this part of the condensed release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants