Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[visulizations] adding schema to saved object mapping #154514

Merged
merged 3 commits into from
May 3, 2023
Merged

[visulizations] adding schema to saved object mapping #154514

merged 3 commits into from
May 3, 2023

Conversation

ppisljar
Copy link
Member

@ppisljar ppisljar commented Apr 6, 2023 •
edited
Loading

Summary

Removes remaining properties that are not searched on from the mapping for the visualizations saved object and adds a schema definition to it.

part of #153070

@ppisljar ppisljar force-pushed the bwca/visualizations branch 2 times, most recently from 77c788d to 6aedcda Compare April 11, 2023 13:43
@ppisljar ppisljar marked this pull request as ready for review April 12, 2023 10:14
@ppisljar ppisljar requested a review from a team as a code owner April 12, 2023 10:14
@ppisljar ppisljar added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Apr 12, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@ppisljar ppisljar force-pushed the bwca/visualizations branch from ebd2076 to 2f8ef43 Compare April 13, 2023 05:10
@ppisljar ppisljar requested a review from a team as a code owner April 13, 2023 05:10
@ppisljar ppisljar force-pushed the bwca/visualizations branch from 2bbf2cb to 9cdb6d1 Compare April 25, 2023 13:29
@ppisljar ppisljar changed the title [visulizations] removing non searched properties from saved object mapping [visulizations] adding schema to saved object mapping Apr 25, 2023
stratoula
stratoula approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, code review only

@rudolf
Copy link
Contributor

rudolf commented Apr 25, 2023

buildkite test this

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ppisljar ppisljar merged commit b3aa580 into elastic:main May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ppisljar @elasticmachine @rudolf @kibana-ci @pgayvallet @stratoula @kibanamachine