Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heatmap small multiples #154434

Merged
merged 23 commits into from
Apr 20, 2023
Merged

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Apr 5, 2023

Summary

Enables split chart in agg based heatmaps (small multiples) and makes the EC implementation the default. It also marks the advanced setting that changes the implementation as deprecated.

image

Checklist

Delete any items that are not applicable to this PR.

@@ -212,7 +212,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});

it('area, bar and heatmap charts', async () => {
await dashboardExpect.seriesElementCount(2);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ I am testing the x labels here instead of the y labels as there is this bug on std deviation #154523

@stratoula stratoula added Feature:Heatmap Heatmap visualization v8.8.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure enhancement New value added to drive a business result release_note:skip Skip the PR/issue when compiling release notes labels Apr 6, 2023
@stratoula stratoula marked this pull request as ready for review April 6, 2023 12:22
@stratoula stratoula requested review from a team as code owners April 6, 2023 12:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presentation team functional test changes LGTM! Code only review

Copy link
Contributor

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still reviewing code and testing it out locally but have a few comments in the meantime.

Copy link
Contributor

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested again locally and all looks good to me! 🎉

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
expressionHeatmap 118 120 +2
visTypeHeatmap 19 18 -1
total +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
expressionHeatmap 89.2KB 90.6KB +1.3KB
visualizations 259.9KB 259.5KB -435.0B
total +934.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visTypeHeatmap 12.5KB 12.2KB -345.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 394 397 +3

Total ESLint disabled count

id before after diff
securitySolution 474 477 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit 544f908 into elastic:main Apr 20, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting enhancement New value added to drive a business result Feature:Heatmap Heatmap visualization release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants