Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Canvas] Restore enabled config in dev #154391

Merged
merged 2 commits into from
Apr 6, 2023

Conversation

cqliu1
Copy link
Contributor

@cqliu1 cqliu1 commented Apr 4, 2023

Summary

Related to #152395.
Closes #154394.

This restores the enabled config setting for the Canvas plugin (in development only for now until #152395 is addressed).

Restoring the xpack.canvas.enabled setting will allow Canvas to be disabled in future offerings.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@cqliu1 cqliu1 added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas canvasGA_0 Feature:Canvas v8.8.0 loe:medium Medium Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. and removed canvasGA_0 labels Apr 4, 2023
@cqliu1 cqliu1 marked this pull request as ready for review April 5, 2023 16:10
@cqliu1 cqliu1 requested a review from a team as a code owner April 5, 2023 16:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@cqliu1 cqliu1 added the Project:Serverless Work as part of the Serverless project for its initial release label Apr 5, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 432 435 +3

Total ESLint disabled count

id before after diff
securitySolution 512 515 +3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cqliu1 cqliu1 added the release_note:skip Skip the PR/issue when compiling release notes label Apr 6, 2023
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested this locally by running with the xpack.canvas.enabled: false config that this introduces, and everything looks great! Kibana runs well without Canvas, and I did some smoke tests in Lens and Dashboard. I also installed all of the sample data sets and the links to Canvas did not show up at all.

@cqliu1 cqliu1 merged commit b222c0a into elastic:main Apr 6, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Canvas impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:Serverless Work as part of the Serverless project for its initial release release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Canvas] Allow Canvas plugin to be disabled via yml
5 participants