[Security Solution][Endpoint][Response Actions] Show shell info above execute action output

[ashokaditya]

Summary

Shows shell name, shell execution return code, and current working directory info along with the command execution output for execute action response.

console

actions history

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Unit or functional tests were updated or added to match the most common scenarios
• Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
• This was checked for cross-browser compatibility

[elasticmachine]

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

[ashokaditya]

So I first went with a version where the labels were not bold similar to other action outputs, but then I switched to the version where the output sections are a bit more legible in terms of contrast with bold. What do you all think?

Here are screenshots without the strong labels.

alternative

cc @caitlinbetz @kevinlog @paul-tavares

[paul-tavares]

@ashokaditya - yeah, I'm not loving the display of it. It just looks like its part of download link information. It just all blends in. Its also pushing the output further down, which might not be a real concern in the console, but in the history log, the user does have limited view windows (expandable row) to see the content, so we're just forcing them to scroll

can you try a few other options and post screen captures?

some Ideas:

• Put it in a accordion above the STDOUT and expanded by default
• lets see what the bold labels view looks like. I think its going to grab too much of the user's eye in this case for something that is not the primary information they are looking to consume, but show it anyway for comparison
• create a "section" labeled "Execution context" and place the content in there. This will at least break up the flow of text and group that information by the label

[ashokaditya]

@ashokaditya - yeah, I'm not loving the display of it. It just looks like its part of download link information. It just all blends in. Its also pushing the output further down, which might not be a real concern in the console, but in the history log, the user does have limited view windows (expandable row) to see the content, so we're just forcing them to scroll

can you try a few other options and post screen captures?

some Ideas:

• Put it in a accordion above the STDOUT and expanded by default
• lets see what the bold labels view looks like. I think its going to grab too much of the user's eye in this case for something that is not the primary information they are looking to consume, but show it anyway for comparison
• create a "section" labeled "Execution context" and place the content in there. This will at least break up the flow of text and group that information by the label

So we agreed in the grooming meeting to move the shell info into an accordion at the top and show it collapsed. Changes added in 9814303

[gergoabraham]

looks and works great! 🚀

[gergoabraham]

nit: instead of toBeTruthy(), it may be semantically better to use toBeInTheDocument(). In this case, you can also use queryByX instead of getByX, so if the queried element is not present, the query function won't fail, but the toBeInTheDocument() will.

[ashokaditya]

Oh I like that better. Will update it

[ashokaditya]

done 177a31b

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 177a31b

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
securitySolution	15.8MB	15.8MB	+1.7KB

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
securitySolution	432	435	+3

Total ESLint disabled count

id	before	after	diff
securitySolution	512	515	+3

History

• 💚 Build #117678 succeeded 79430d6
• 💛 Build #117651 was flaky e331813
• 💔 Build #117624 failed 98de0ba

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ashokaditya