fixes pie label conflict resolution #15410
Conversation
ppisljar
added
Feature:Visualizations
| @@ -244,7 +244,7 @@ export function VislibVisualizationsPieChartProvider(Private) { | |||
| x: pos[0], | |||
| y: pos[1], | |||
| left: midAngle < Math.PI ? pos[0] : pos[0] - bbox.width, | |||
| right: midAngle > Math.PI ? pos[0] + bbox.width : pos[0], | |||
| right: midAngle < Math.PI ? pos[0] + bbox.width : pos[0], | |||
There was a problem hiding this comment.
ups, that shouldn't be there. thanks!
* fixes pie label conflict resolution * fixing based on review
* fixes pie label conflict resolution * fixing based on review
| @@ -258,8 +258,8 @@ export function VislibVisualizationsPieChartProvider(Private) { | |||
| const current = d.position; | |||
| if (point) { | |||
| const horizontalConflict = (point.left < 0 && current.left < 0) || (point.left > 0 && current.left > 0); | |||
| const verticalConflict = (point.top > current.top && point.top <= current.bottom) || | |||
| (point.top < current.top && point.bottom >= current.top); | |||
| const verticalConflict = (point.top >= current.top && point.top <= current.bottom) || | |||
There was a problem hiding this comment.
This fix does solve the conflict but It hide the label which conflict with other which looks like a bug. (missing label)
What it should do is to try to find a better place to be shown. Usually there is still plenty of space
There was a problem hiding this comment.
The same happens with labels on the same level as well, if conflict is detected its just hidden. Could you open a separate enhancement request for trying to find new position for the label if it is in conflict with another ? (i had this implemented but we decided to move it out of the original PR as the algorithm i was using was resource intensive)
There was a problem hiding this comment.
where can I see the code for trying to find new position for the label if it is in conflict with another?
There was a problem hiding this comment.
In addition ,I opened feature request: #15571
resolves #15406
scenario when two labels would be positioned at exactly the same place was not handled correctly