-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX] Use components from Exploratory View app in UX #154051
[UX] Use components from Exploratory View app in UX #154051
Conversation
Pinging @elastic/uptime (Team:uptime) |
π€ GitHub commentsExpand to view the GitHub comments
Just comment with:
|
β¦direct-users-from-obs-exploratory-view-to-app-exploratory-view
π Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
FieldValueSuggestions, | ||
FieldValueSelection, | ||
FilterValueLabel, | ||
SelectableUrlList, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these components belong in shared place in observability in my opinion. They are not part of exp view and are used in other places as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These components are not used in any app other than Ux and Synthetics, and when these apps use them, they only use them in the context of the Exploratory View feature.
Therefore it makes sense to keep them close to the Exploratory View app, where they are used. Alternatively, they could be stored in Ux, in Synthetics or a package that these apps share.
By keeping them in the Exploratory View application, the Synthetics team has full freedom to develop them further, and make sure they work correctly within the context of the Exploratory View app.
const e2eDir = path.join(__dirname, '../e2e'); | ||
|
||
executeSyntheticsRunner(e2eDir); | ||
console.log('Disabled.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will in a following PR. Removing it in this PR means removing files owned by Ops, which will slow down this review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Resolves #154053
π Summary
Now that the Exploratory View route is placed in its own application, the UX app can safely use components related to the Exploratory View from that application.
β Acceptance Criteria