Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Use components from Exploratory View app in UX #154051

Conversation

CoenWarmer
Copy link
Contributor

@CoenWarmer CoenWarmer commented Mar 30, 2023

Resolves #154053

πŸ“ Summary

Now that the Exploratory View route is placed in its own application, the UX app can safely use components related to the Exploratory View from that application.

βœ… Acceptance Criteria

  • UX app should behave and function exactly the same as before.

@CoenWarmer CoenWarmer requested a review from a team as a code owner March 30, 2023 13:44
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Mar 30, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@apmmachine
Copy link
Contributor

πŸ€– GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@CoenWarmer CoenWarmer added the release_note:skip Skip the PR/issue when compiling release notes label Mar 30, 2023
@CoenWarmer CoenWarmer changed the title Use components from Exploratory View app in UX [UX] Use components from Exploratory View app in UX Mar 30, 2023
@CoenWarmer CoenWarmer requested a review from a team as a code owner March 30, 2023 14:28
@kibana-ci
Copy link
Collaborator

πŸ’š Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ux 141 142 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
exploratoryView 339 349 +10

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ux 160.8KB 161.0KB +158.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
exploratoryView 17 22 +5

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
exploratoryView 58.6KB 59.6KB +1.0KB
Unknown metric groups

API count

id before after diff
exploratoryView 342 352 +10

ESLint disabled line counts

id before after diff
securitySolution 432 435 +3

Total ESLint disabled count

id before after diff
securitySolution 512 515 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Comment on lines +45 to +48
FieldValueSuggestions,
FieldValueSelection,
FilterValueLabel,
SelectableUrlList,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these components belong in shared place in observability in my opinion. They are not part of exp view and are used in other places as well.

Copy link
Contributor Author

@CoenWarmer CoenWarmer Mar 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These components are not used in any app other than Ux and Synthetics, and when these apps use them, they only use them in the context of the Exploratory View feature.

Therefore it makes sense to keep them close to the Exploratory View app, where they are used. Alternatively, they could be stored in Ux, in Synthetics or a package that these apps share.

By keeping them in the Exploratory View application, the Synthetics team has full freedom to develop them further, and make sure they work correctly within the context of the Exploratory View app.

const e2eDir = path.join(__dirname, '../e2e');

executeSyntheticsRunner(e2eDir);
console.log('Disabled.');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not remove it?

Copy link
Contributor Author

@CoenWarmer CoenWarmer Mar 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will in a following PR. Removing it in this PR means removing files owned by Ops, which will slow down this review.

Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

App still seems to be working fine
image

though it's doing a full page when user is trying to dig deep into exploratory view embeddable via explore button

Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CoenWarmer CoenWarmer merged commit 59f7d1a into elastic:main Mar 31, 2023
@CoenWarmer CoenWarmer deleted the chore/153940-redirect-users-from-obs-exploratory-view-to-app-exploratory-view branch March 31, 2023 13:30
@kibanamachine kibanamachine added v8.8.0 backport:skip This commit does not require backporting labels Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Exploratory View] Update UX app to use components from Exploratory View app
7 participants