-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Disable TSBD setting switch when enabled #154048
[Fleet] Disable TSBD setting switch when enabled #154048
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
c857d26
to
e48197e
Compare
Pinging @elastic/fleet (Team:Fleet) |
@elasticmachine merge upstream |
Should we add a tooltip or similar to let the user know why the checkbox is disabled? I'm not 100% sure on this, just interested in other peoples thoughts |
👍🏼 Let's add something quick and easy. |
@jlind23 Who should I consult with to validate the tooltip message? |
@karenzone might be our best asset here. |
A comment on the option itself... The description and the abbreviation should be aligned. Similarly for the tooltip: |
5ddecbe
to
0ab338d
Compare
…-ref HEAD~1..HEAD --fix'
@karenzone I have made the changes and uploaded updated screenshots to the PR description based on your feedback. |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Summary
Disable
Time-series indexing (TSDB)
switch in experimental datastream settings if TSDB is enabled in the package itself.As part of this fix, the following changes are included in compliance with UX rules:
Time-series indexing (TSDB)
toTime-series database (TSDB) indexing
.TSDB indexing is enabled by the integration
.Closes #152778
Screenshots
Before
After
When the integration does NOT enable TSDB:
When the integration DOES enable TSDB:
Steps to test locally
Refer to the original PR for extended context.
Testing a package without TSDB
Collect metrics from System instances -> System cpu metrics -> Advanced options
settings, theTime-series indexing (TSDB)
switch should be off and enabled (you should be able to toggle it on and off).Testing a package with TSDB
cd packages/system && elastic-package build
elastic-package stack up -d -v --services package-registry
kibana.dev.yml
, addxpack.fleet.registryUrl: https://localhost:8080
if not there already.kibana.dev.yml
, addxpack.fleet.enableExperimental: ['experimentalDataStreamSettings']
if not there already.yarn start
, runexport NODE_EXTRA_CA_CERTS=$HOME/.elastic-package/profiles/default/certs/kibana/ca-cert.pem
in the same shell. This is to set up the certificate needed to access EPR with https.Collect metrics from System instances -> System cpu metrics -> Advanced options
settings, theTime-series indexing (TSDB)
switch should be on and disabled. There should be a question mark icon with a tooltip.