Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HTTP] Expose versioned router #153858

Merged
merged 51 commits into from
Apr 3, 2023
Merged
Changes from 1 commit
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
cfd23a7
moved ApiVersion type to common http package
jloleysens Mar 28, 2023
5a41847
runtime check for version number
jloleysens Mar 28, 2023
52b25b9
rename shared version header constant, added test for passing through…
jloleysens Mar 28, 2023
ffa9f66
move route validator to own package so that it can be shared
jloleysens Mar 28, 2023
ba1a3a1
ran yarn kbn bootstrap
jloleysens Mar 28, 2023
9d7506d
import route validator from new package
jloleysens Mar 28, 2023
2db39e1
remove dependence on core internal router
jloleysens Mar 28, 2023
8af51c5
pointless change to tsconfig.json
jloleysens Mar 28, 2023
f937521
remove dependence on core internal router
jloleysens Mar 28, 2023
6f01b5c
fix mock response factory
jloleysens Mar 28, 2023
25d6249
added versioned router mocks
jloleysens Mar 28, 2023
983596b
ran yarn kbn bootstrap
jloleysens Mar 28, 2023
ce98092
added versioned router mock
jloleysens Mar 28, 2023
b8c694e
merge imports from same package
jloleysens Mar 28, 2023
1364c7a
expose the versioned router on the IRouter interface
jloleysens Mar 28, 2023
b98044b
added an example and removed auto return type inference
jloleysens Mar 28, 2023
02f330d
fix output validation by actually passing in the response :facepalm: …
jloleysens Mar 28, 2023
7b88ded
just use the const
jloleysens Mar 28, 2023
f67e2d5
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine Mar 28, 2023
a27e49f
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
kibanamachine Mar 28, 2023
3ad27c0
remove circular dep
jloleysens Mar 28, 2023
d9d05d5
added IRouterWithVersion to address type woes
jloleysens Mar 28, 2023
e75ed38
Merge branch 'main' into expose-versioned-router
jloleysens Mar 28, 2023
ab53f28
make default for checking responses false and update tests
jloleysens Mar 28, 2023
9665928
make body, param, query nullable
jloleysens Mar 29, 2023
37cef77
added some integration tests for the versioned router
jloleysens Mar 29, 2023
e0538cf
mock out badRequest
jloleysens Mar 29, 2023
435b26f
Merge branch 'main' into expose-versioned-router
jloleysens Mar 29, 2023
047dfce
Merge branch 'main' into expose-versioned-router
jloleysens Mar 30, 2023
1fff686
do better than any
jloleysens Mar 31, 2023
a3fd786
remove inline class def
jloleysens Mar 31, 2023
5635219
factor out route version validation logic
jloleysens Mar 31, 2023
e6e8eed
added validation function
jloleysens Mar 31, 2023
03ab1b9
added test and fixed logic
jloleysens Mar 31, 2023
9a3e7c7
added integration test case for missing version header
jloleysens Mar 31, 2023
42ed016
fix typo
jloleysens Mar 31, 2023
6a67877
Merge branch 'main' into expose-versioned-router
jloleysens Apr 3, 2023
fa60493
move versioned router mock
jloleysens Apr 3, 2023
f2a532b
update exports and use the versioned router mock
jloleysens Apr 3, 2023
3ddc635
move versioned router implementation
jloleysens Apr 3, 2023
3489693
remove the validator package
jloleysens Apr 3, 2023
ca0c431
update a few import paths and ts config references
jloleysens Apr 3, 2023
3ea8c48
remove ts project reference
jloleysens Apr 3, 2023
41df80c
go back to using actual CoreKibanaRequest!
jloleysens Apr 3, 2023
154821a
ran yarn kbn bootstrap
jloleysens Apr 3, 2023
40fd5e1
remove 3 unnecessary code owners entries
jloleysens Apr 3, 2023
3d51eec
remove unnecessary default
jloleysens Apr 3, 2023
5388234
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine Apr 3, 2023
e723e06
change the version missing response
jloleysens Apr 3, 2023
df0211a
Merge branch 'main' into expose-versioned-router
jloleysens Apr 3, 2023
2c5c840
Merge branch 'main' into expose-versioned-router
jloleysens Apr 3, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into expose-versioned-router
jloleysens authored Mar 28, 2023

Verified

This commit was signed with the committer’s verified signature.
markov00 Marco Vettorello
commit e75ed38bbff8d623c11b590ea6400ccac1003e91

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.