Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Observability] Copy Exploratory View into a separate app #153852

Conversation

CoenWarmer
Copy link
Contributor

@CoenWarmer CoenWarmer commented Mar 28, 2023

Resolves #153830

📝 Summary

This PR copies the Exploratory View component that was inside the Observability app into its own app.

Screenshot 2023-03-23 at 13 14 35

  • URL of new app: app/exploratory-view
  • Design and functionality are unchanged.
  • All links to the route inside Synthetics and UX have been updated to the new app. The links in APM will be updated in a new PR to keep the PR smaller.
  • Git history has been retained for all files in x-pack/plugins/exploratory_view.
  • The Exploratory View component inside Observability will be removed in a following PR.

@github-actions
Copy link
Contributor

Documentation preview:

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@CoenWarmer CoenWarmer force-pushed the chore/move-exploratory-view-to-separate-app-with-git-history branch from 99e67d0 to d615dbd Compare March 28, 2023 10:47
kibanamachine and others added 9 commits March 28, 2023 10:54
…story' of github.com:CoenWarmer/kibana into chore/move-exploratory-view-to-separate-app-with-git-history
github.com:elastic/kibana into chore/move-exploratory-view-to-separate-app-with-git-history
…story' of github.com:CoenWarmer/kibana into chore/move-exploratory-view-to-separate-app-with-git-history
@CoenWarmer CoenWarmer marked this pull request as ready for review March 28, 2023 14:23
@CoenWarmer CoenWarmer requested review from a team as code owners March 28, 2023 14:23
@CoenWarmer CoenWarmer added release_note:feature Makes this part of the condensed release notes backport:skip This commit does not require backporting labels Mar 28, 2023
…oratory-view-to-separate-app-with-git-history
…story' of github.com:CoenWarmer/kibana into chore/move-exploratory-view-to-separate-app-with-git-history
…oratory-view-to-separate-app-with-git-history
@CoenWarmer CoenWarmer force-pushed the chore/move-exploratory-view-to-separate-app-with-git-history branch from 930d1e6 to 5a11c95 Compare March 28, 2023 21:08
…oratory-view-to-separate-app-with-git-history
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
exploratoryView - 207 +207

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
exploratoryView - 339 +339
observability 644 646 +2
total +341

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
exploratoryView - 4 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
exploratoryView - 242.6KB ⚠️ +242.6KB
synthetics 1.4MB 1.4MB +33.0B
total +242.6KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
exploratoryView - 17 +17

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
exploratoryView - 58.6KB +58.6KB
observability 89.0KB 89.1KB +148.0B
synthetics 26.8KB 27.1KB +371.0B
ux 5.9KB 6.1KB +243.0B
total +59.4KB
Unknown metric groups

API count

id before after diff
exploratoryView - 342 +342
observability 650 652 +2
total +344

async chunk count

id before after diff
exploratoryView - 12 +12

ESLint disabled in files

id before after diff
exploratoryView - 3 +3

ESLint disabled line counts

id before after diff
exploratoryView - 32 +32
securitySolution 433 436 +3
total +35

References to deprecated APIs

id before after diff
exploratoryView - 66 +66

Total ESLint disabled count

id before after diff
exploratoryView - 35 +35
securitySolution 513 516 +3
total +38

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@maryam-saeidi maryam-saeidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AO changes LGTM

@CoenWarmer CoenWarmer enabled auto-merge (squash) March 29, 2023 08:30
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as standalone app.

Need a follow up to clean up the usage and unrelated files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Exploratory View release_note:feature Makes this part of the condensed release notes v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Observability][Synthetics] Move Exploratory View route into a separate app
9 participants