[Files] Tests for createEsFileClient() usage when indexAsAlias option and minor refactor
#153815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-tavares
added
release_note:skip
…index-as-alias-change' into task/olm-files-plugin-tests-for-index-as-alias-change
paul-tavares
commented
Mar 28, 2023
| it('should be an empty stream on empty response', async () => { | ||
| client.get.mockResponseOnce(toReadable()); | ||
| const onData = jest.fn(); | ||
| describe('with `indexIsAlias` set to `false`', () => { |
There was a problem hiding this comment.
From here down, everything is the same as before. All I did was wrap the test cases in a describe() whose title is more descriptive of that block of tests.
Here is a screen capture from my IDE:
paul-tavares
commented
Mar 28, 2023
| const { esClient, index, indexIsAlias } = this; | ||
| let doc: FileDocument<M> | undefined; | ||
|
|
||
| if (indexIsAlias) { |
There was a problem hiding this comment.
Removed fetchDoc() utility since it was only being used here and moved the implementation here.
paul-tavares
commented
Mar 28, 2023
|
|
||
| if (!doc) { | ||
| this.logger.error(`File with id "${id}" not found`); | ||
| this.logger.error( |
There was a problem hiding this comment.
@jloleysens - I think this addresses your comment in the prior PR. If .search() does not find the doc, then it will throw an error here.
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
paul-tavares
deleted the
task/olm-files-plugin-tests-for-index-as-alias-change
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR builds on top of #153342 and:
indexAsAliasoption that was added tocreateEsFileClient()fetchDoc()utility (not needed)