[data views] Implement content management api

src/plugins/data/common/search/expressions/kibana_context.test.ts

@@ -46,6 +46,7 @@ describe('kibanaContextFn', () => {
         delete: jest.fn(),
         find: jest.fn(),
         get: jest.fn(),
+        getSavedSearch: jest.fn(),
         update: jest.fn(),
       },
     };

src/plugins/data/common/search/expressions/kibana_context.ts

@@ -129,7 +129,7 @@ export const getKibanaContextFn = (
       let filters = [...(input?.filters || [])];
 
       if (args.savedSearchId) {
-        const obj = await savedObjectsClient.get('search', args.savedSearchId);
+        const obj = await savedObjectsClient.getSavedSearch(args.savedSearchId);
         const search = (obj.attributes as any).kibanaSavedObjectMeta.searchSourceJSON as string;
         const { query, filter } = getParsedValue(search, {});
 

src/plugins/data_view_management/public/components/edit_index_pattern/indexed_fields_table/indexed_fields_table.tsx

@@ -76,6 +76,7 @@ export class IndexedFieldsTable extends Component<
         fields.map((field) => {
           return {
             ...field.spec,
+            id: field.name,
             type: field.esTypes?.join(', ') || '',
             kbnType: field.type,
             displayName: field.displayName,
@@ -114,6 +115,7 @@ export class IndexedFieldsTable extends Component<
           },
         },
         name,
+        id: name,
         type: 'composite',
         kbnType: '',
         displayName: name,

src/plugins/data_views/common/content_management/constants.ts

@@ -0,0 +1,14 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+
+/**
+ * Data view saved object version.
+ */
+export const LATEST_VERSION = 1;
+
+export const DataViewContentType = 'index-pattern';

src/plugins/data_views/common/content_management/index.ts

@@ -0,0 +1,28 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+
+export { LATEST_VERSION } from './constants';
+
+export type {
+  DataViewSavedObject,
+  DataViewGetIn,
+  DataViewGetOut,
+  DataViewCreateIn,
+  DataViewCreateOut,
+  CreateOptions,
+  DataViewUpdateIn,
+  DataViewUpdateOut,
+  UpdateOptions,
+  DataViewDeleteIn,
+  DataViewDeleteOut,
+  DataViewSearchIn,
+  DataViewSearchOut,
+  DataViewSearchQuery,
+} from './types';
+
+export { DataViewContentType } from './constants';

src/plugins/data_views/common/content_management/types.ts

@@ -0,0 +1,115 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+
+import type {
+  SavedObject,
+  SavedObjectReference,
+  SavedObjectsResolveResponse,
+  SavedObjectsUpdateResponse,
+} from '@kbn/core-saved-objects-api-server';
+import type { SavedObjectsMigrationVersion } from '@kbn/core-saved-objects-common';
+
+import type {
+  GetIn,
+  CreateIn,
+  SearchIn,
+  UpdateIn,
+  DeleteIn,
+} from '@kbn/content-management-plugin/common';
+
+import { DataViewAttributes } from '../types';
+import { DataViewContentType } from './constants';
+
+interface Reference {
+  type: string;
+  id: string;
+}
+
+export type DataViewSavedObject = SavedObject<DataViewAttributes>;
+
+// ----------- GET --------------
+
+export type DataViewGetIn = GetIn<typeof DataViewContentType>;
+
+export interface DataViewGetOut {
+  savedObject: SavedObjectsResolveResponse<DataViewAttributes>['saved_object'];
+  outcome: SavedObjectsResolveResponse['outcome'];
+  aliasTargetId: SavedObjectsResolveResponse['alias_target_id'];
+  aliasPurpose: SavedObjectsResolveResponse['alias_purpose'];
+}
+
+// ----------- CREATE --------------
+
+export interface CreateOptions {
+  /** If a document with the given `id` already exists, overwrite it's contents (default=false). */
+  overwrite?: boolean;
+  migrationVersion?: SavedObjectsMigrationVersion;
+  /** A semver value that is used when upgrading objects between Kibana versions. */
+  coreMigrationVersion?: string;
+  /** Array of referenced saved objects. */
+  references?: SavedObjectReference[];
+}
+
+export type DataViewCreateIn = CreateIn<
+  typeof DataViewContentType,
+  DataViewAttributes,
+  CreateOptions
+>;
+
+export type DataViewCreateOut = DataViewSavedObject;
+
+// ----------- UPDATE --------------
+
+export interface UpdateOptions {
+  /** Array of referenced saved objects. */
+  references?: SavedObjectReference[];
+}
+
+export type DataViewUpdateIn = UpdateIn<
+  typeof DataViewContentType,
+  DataViewAttributes,
+  UpdateOptions
+>;
+
+export type DataViewUpdateOut = SavedObjectsUpdateResponse<DataViewAttributes>;
+
+// ----------- DELETE --------------
+
+export type DataViewDeleteIn = DeleteIn<typeof DataViewContentType>;
+
+export interface DataViewDeleteOut {
+  status: 'success';
+}
+
+// ----------- SEARCH --------------
+
+export interface DataViewSearchQuery {
+  search?: string;
+  fields?: string[];
+  searchFields?: string[];
+  perPage?: number;
+  page?: number;
+  defaultSearchOperator?: 'AND' | 'OR';
+  hasReference?: Reference | Reference[];
+  hasNoReference?: Reference | Reference[];
+}
+
+export type DataViewSearchIn = SearchIn<typeof DataViewContentType, DataViewSearchQuery>;
+
+export interface DataViewSearchOut {
+  /** current page in results*/
+  page: number;
+  /** number of results per page */
+  perPage: number;
+  /** total number of results */
+  total: number;
+  /** Array of simple saved objects */
+  savedObjects: DataViewSavedObject[];
+  /** aggregations from the search query */
+  aggregations?: unknown; // TODO: Check if used in Maps
+}

src/plugins/data_views/common/data_views/data_views.ts

@@ -31,6 +31,7 @@ import {
   DataViewFieldMap,
   TypeMeta,
 } from '../types';
+
 import { META_FIELDS, SavedObject } from '..';
 import { DataViewMissingIndices } from '../lib';
 import { findByName } from '../utils';
@@ -175,7 +176,7 @@ export interface DataViewsServicePublicMethods {
    * Delete data view
    * @param indexPatternId - Id of the data view to delete.
    */
-  delete: (indexPatternId: string) => Promise<{}>;
+  delete: (indexPatternId: string) => Promise<void>;
   /**
    * Takes field array and field attributes and returns field map by name.
    * @param fields - Array of fieldspecs
@@ -349,7 +350,7 @@ export class DataViewsService {
    * Refresh cache of index pattern ids and titles.
    */
   private async refreshSavedObjectsCache() {
-    const so = await this.savedObjectsClient.find<DataViewSavedObjectAttrs>({
+    const so = await this.savedObjectsClient.find({
       type: DATA_VIEW_SAVED_OBJECT_TYPE,
       fields: ['title', 'type', 'typeMeta', 'name'],
       perPage: 10000,
@@ -392,7 +393,7 @@ export class DataViewsService {
    * @returns DataView[]
    */
   find = async (search: string, size: number = 10): Promise<DataView[]> => {
-    const savedObjects = await this.savedObjectsClient.find<DataViewSavedObjectAttrs>({
+    const savedObjects = await this.savedObjectsClient.find({
       type: DATA_VIEW_SAVED_OBJECT_TYPE,
       fields: ['title'],
       search,
@@ -726,10 +727,7 @@ export class DataViewsService {
     id: string,
     displayErrors: boolean = true
   ): Promise<DataView> => {
-    const savedObject = await this.savedObjectsClient.get<DataViewAttributes>(
-      DATA_VIEW_SAVED_OBJECT_TYPE,
-      id
-    );
+    const savedObject = await this.savedObjectsClient.get(id);
 
     if (!savedObject.version) {
       throw new SavedObjectNotFound('data view', id, 'management/kibana/dataViews');
@@ -1006,13 +1004,9 @@ export class DataViewsService {
     }
 
     const body = dataView.getAsSavedObjectBody();
-    const response: SavedObject<DataViewAttributes> = (await this.savedObjectsClient.create(
-      DATA_VIEW_SAVED_OBJECT_TYPE,
-      body,
-      {
-        id: dataView.id,
-      }
-    )) as SavedObject<DataViewAttributes>;
+    const response: SavedObject<DataViewAttributes> = (await this.savedObjectsClient.create(body, {
+      id: dataView.id,
+    })) as SavedObject<DataViewAttributes>;
 
     const createdIndexPattern = await this.initFromSavedObject(response, displayErrors);
     if (this.savedObjectsCache) {
@@ -1054,7 +1048,7 @@ export class DataViewsService {
     });
 
     return this.savedObjectsClient
-      .update(DATA_VIEW_SAVED_OBJECT_TYPE, indexPattern.id, body, {
+      .update(indexPattern.id, body, {
         version: indexPattern.version,
       })
       .then((response) => {
@@ -1135,7 +1129,7 @@ export class DataViewsService {
       throw new DataViewInsufficientAccessError(indexPatternId);
     }
     this.dataViewCache.clear(indexPatternId);
-    return this.savedObjectsClient.delete(DATA_VIEW_SAVED_OBJECT_TYPE, indexPatternId);
+    return this.savedObjectsClient.delete(indexPatternId);
   }
 
   /**

src/plugins/data_views/common/index.ts

@@ -13,6 +13,8 @@ export {
   DATA_VIEW_SAVED_OBJECT_TYPE,
 } from './constants';
 
+export { LATEST_VERSION } from './content_management';
+
 export type { ToSpecConfig } from './fields';
 export type { IIndexPatternFieldList } from './fields';
 export {