[Enterprise Search] [Search application] List indices fetch indices stats from ES directly #153696

saarikabhasi · 2023-03-24T19:05:22Z

Summary

This PR adds a lib file which fetches the indices stats of an search application from Elasticsearch directly

Screenshot

List page indices

Overview page indices

Checklist

Unit or functional tests were updated or added to match the most common scenarios

saarikabhasi · 2023-03-24T19:14:35Z

x-pack/plugins/enterprise_search/common/types/engines.ts

@@ -20,11 +20,14 @@ export interface EnterpriseSearchEngine {
 }

 export interface EnterpriseSearchEngineDetails {
-  indices: EnterpriseSearchEngineIndex[];
+  indices: string[];


indices are of type string[] from ES but the hydrated indices is of type EnterpriseSearchEngineIndex[]. Hence added EnterpriseSearchEngineDetailsResponse

This type was only needed because the get engine & list engines results differed. since this is returning indices: string[]; now we can just use EnterpriseSearchEngine as the types are the same.

kderusso

Nice and clean! One nitpick, could you please update the PR title to be more descriptive of the change? Thank you!

sphilipse

Nice job! Just one spelling nitpick

sphilipse · 2023-03-27T14:16:25Z

x-pack/plugins/enterprise_search/server/lib/engines/fetch_indices_stats.ts

+    metric: ['docs'],
+  });
+  const indicesWithStats = indicesNames.map((indexName: string) => {
+    const indiceStats = indicesStats[indexName];


nitpick(non-blocking): indiceStats should be indicesStats (or maybe indexStats).

saarikabhasi · 2023-03-27T20:21:24Z

@elasticmachine merge upstream

TattdCodeMonkey · 2023-03-27T21:22:59Z

x-pack/plugins/enterprise_search/common/types/engines.ts

  updated_at_millis: number;
  name: string;
 }
-
+export interface EnterpriseSearchEngineDetailsResponse


introducing this type doesn't make sense to me. I think we should update EnterpriseSearchEngineDetails with indices: EnterpriseSearchEngineIndex[]; instead of introducing another interface here.

…ne interface

saarikabhasi · 2023-03-27T23:35:35Z

@elasticmachine merge upstream

TattdCodeMonkey · 2023-03-28T13:54:56Z

x-pack/plugins/enterprise_search/common/types/engines.ts

@@ -14,15 +14,9 @@ export interface EnterpriseSearchEnginesResponse {
 }

 export interface EnterpriseSearchEngine {


are we hydrating indices with the full index data for the list request?

List all engines and GET a engine request returns list indices names in String[]

We are fetching indices data (stats) from ES directly. Logic added in this file.
https://github.com/elastic/kibana/blob/7eb14bf51a9912f4bbf82afe8018d2ee3b3a9120/x-pack/plugins/enterprise_search/server/lib/engines/fetch_indices_stats.ts

TattdCodeMonkey · 2023-03-28T14:02:58Z

x-pack/plugins/enterprise_search/common/types/engines.ts

-  updated_at_millis: number;
-}
-
-export interface EnterpriseSearchEngineDetails {


We'll still need this type to be different from EnterpriseSearchEngine since the list and get responses return different data. List results has indices: string[] and should use EnterpriseSearchEngine and the get for a single search application will need to return a EnterpriseSearchEngineDetails which has the indices hydrated.

Yeah it make sense.

General question:

If we define indices: EnterpriseSearchEngineIndex[] in EnterpriseSearchEngineDetails but GET a single search application response indices type is String[] would that be any issue in general ?

On side note we do update the hydrated indices in here

saarikabhasi · 2023-03-28T15:24:31Z

`@elasticmachine merge upstream

saarikabhasi · 2023-03-28T16:22:27Z

@elasticmachine merge upstream

…-ref HEAD~1..HEAD --fix'

x-pack/plugins/enterprise_search/server/routes/enterprise_search/engines.ts

...earch/public/applications/enterprise_search_content/components/engines/engines_list_logic.ts

x-pack/plugins/enterprise_search/common/types/engines.ts

kibana-ci · 2023-03-30T15:56:36Z

💚 Build Succeeded

Buildkite Build
Commit: 4e0f7bf

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`securitySolution`	432	435	+3

Total ESLint disabled count

id	before	after	diff
`securitySolution`	512	515	+3

History

💔 Build #116756 failed 103f9bb
💚 Build #116473 succeeded 6100bc9
💚 Build #116423 succeeded 13f58ae3224f5a44978ee852880bdd0702790464
💔 Build #116399 failed 5ba36eb6d8cb3a77543240e3abd1cffce88bb9a6
💚 Build #116211 succeeded f1cc0a3
💔 Build #116200 failed 1a86d67

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Initial commit

a4c18b9

saarikabhasi marked this pull request as ready for review March 24, 2023 19:12

saarikabhasi requested a review from a team March 24, 2023 19:12

saarikabhasi commented Mar 24, 2023

View reviewed changes

kderusso reviewed Mar 24, 2023

View reviewed changes

saarikabhasi changed the title ~~Initial commit~~ [Enterprise Search] [Search application] List indices fetch indices stats from ES directly Mar 24, 2023

saarikabhasi added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.8.0 Team:EnterpriseSearch labels Mar 24, 2023

saarikabhasi requested a review from a team March 24, 2023 19:20

sphilipse approved these changes Mar 27, 2023

View reviewed changes

sloanelybutsurely approved these changes Mar 27, 2023

View reviewed changes

Fix failing test case and some clean ups

6916094

saarikabhasi force-pushed the search-app-update-list-page branch from 8d3baf7 to 6916094 Compare March 27, 2023 20:20

TattdCodeMonkey reviewed Mar 27, 2023

View reviewed changes

saarikabhasi force-pushed the search-app-update-list-page branch from d30f363 to 1e3a2f3 Compare March 27, 2023 23:33

PR comment- remove response interface and update EnterpriseSearchEngi…

705935b

…ne interface

saarikabhasi force-pushed the search-app-update-list-page branch from 1e3a2f3 to 705935b Compare March 27, 2023 23:35

joemcelroy approved these changes Mar 28, 2023

View reviewed changes

TattdCodeMonkey reviewed Mar 28, 2023

View reviewed changes

revert back to EnterpriseSearchEngineDetails

ea21c98

saarikabhasi force-pushed the search-app-update-list-page branch from 7eb14bf to ea21c98 Compare March 28, 2023 15:24

kibanamachine and others added 2 commits March 28, 2023 12:22

Merge branch 'main' into search-app-update-list-page

62c0560

Merge branch 'main' into search-app-update-list-page

caecfeb

kibanamachine and others added 2 commits March 28, 2023 17:37

[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…

4645175

…-ref HEAD~1..HEAD --fix'

Merge branch 'main' into search-app-update-list-page

1a86d67

saarikabhasi requested a review from TattdCodeMonkey March 28, 2023 18:24

fix failing check types

f1cc0a3

TattdCodeMonkey reviewed Mar 28, 2023

View reviewed changes

changed get/search app return type to EnterpriseSearchEngine

bcf0896

saarikabhasi force-pushed the search-app-update-list-page branch from 5ba36eb to c383c5f Compare March 29, 2023 14:07

saarikabhasi requested a review from TattdCodeMonkey March 29, 2023 15:34

Fix failing test case and Remove type cast from indices test file

6100bc9

saarikabhasi force-pushed the search-app-update-list-page branch from 13f58ae to 6100bc9 Compare March 29, 2023 15:39

TattdCodeMonkey approved these changes Mar 29, 2023

View reviewed changes

Merge branch 'main' into search-app-update-list-page

103f9bb

saarikabhasi enabled auto-merge (squash) March 30, 2023 13:28

Merge branch 'main' into search-app-update-list-page

4e0f7bf

saarikabhasi merged commit 327dd49 into elastic:main Mar 30, 2023

saarikabhasi deleted the search-app-update-list-page branch March 30, 2023 15:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Enterprise Search] [Search application] List indices fetch indices stats from ES directly #153696

[Enterprise Search] [Search application] List indices fetch indices stats from ES directly #153696

saarikabhasi commented Mar 24, 2023 •

edited

Loading

saarikabhasi Mar 24, 2023

TattdCodeMonkey Mar 27, 2023

kderusso left a comment

sphilipse left a comment

sphilipse Mar 27, 2023

saarikabhasi commented Mar 27, 2023

TattdCodeMonkey Mar 27, 2023 •

edited

Loading

saarikabhasi commented Mar 27, 2023

TattdCodeMonkey Mar 28, 2023 •

edited

Loading

saarikabhasi Mar 28, 2023

saarikabhasi Mar 28, 2023

TattdCodeMonkey Mar 28, 2023

saarikabhasi Mar 28, 2023

saarikabhasi commented Mar 28, 2023

saarikabhasi commented Mar 28, 2023

kibana-ci commented Mar 30, 2023

ESLint disabled line counts

Total ESLint disabled count

		@@ -14,15 +14,9 @@ export interface EnterpriseSearchEnginesResponse {
		}

		export interface EnterpriseSearchEngine {

[Enterprise Search] [Search application] List indices fetch indices stats from ES directly #153696

[Enterprise Search] [Search application] List indices fetch indices stats from ES directly #153696

Conversation

saarikabhasi commented Mar 24, 2023 • edited Loading

Summary

Screenshot

List page indices

Overview page indices

Checklist

saarikabhasi Mar 24, 2023

Choose a reason for hiding this comment

TattdCodeMonkey Mar 27, 2023

Choose a reason for hiding this comment

kderusso left a comment

Choose a reason for hiding this comment

sphilipse left a comment

Choose a reason for hiding this comment

sphilipse Mar 27, 2023

Choose a reason for hiding this comment

saarikabhasi commented Mar 27, 2023

TattdCodeMonkey Mar 27, 2023 • edited Loading

Choose a reason for hiding this comment

saarikabhasi commented Mar 27, 2023

TattdCodeMonkey Mar 28, 2023 • edited Loading

Choose a reason for hiding this comment

saarikabhasi Mar 28, 2023

Choose a reason for hiding this comment

saarikabhasi Mar 28, 2023

Choose a reason for hiding this comment

TattdCodeMonkey Mar 28, 2023

Choose a reason for hiding this comment

saarikabhasi Mar 28, 2023

Choose a reason for hiding this comment

saarikabhasi commented Mar 28, 2023

saarikabhasi commented Mar 28, 2023

kibana-ci commented Mar 30, 2023

💚 Build Succeeded

Metrics [docs]

ESLint disabled line counts

Total ESLint disabled count

History

saarikabhasi commented Mar 24, 2023 •

edited

Loading

TattdCodeMonkey Mar 27, 2023 •

edited

Loading

TattdCodeMonkey Mar 28, 2023 •

edited

Loading