Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Observability] Copy Exploratory View into a separate app #153541

Conversation

CoenWarmer
Copy link
Contributor

@CoenWarmer CoenWarmer commented Mar 23, 2023

Resolves #153830

📝 Summary

This PR extracts the Exploratory View component that was inside the Observability app into its own app.

This is done to establish clearer boundaries between code owned by the Actionable Observability team and the Synthetics team.

All links to this route inside consuming applications (APM, Synthetics and UX) have been updated.

Screenshot 2023-03-23 at 13 14 35

Changes:

  • URL updated: app/observability/exploratory-view => app/exploratory-view
  • Design and functionality are unchanged.

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@CoenWarmer CoenWarmer added the release_note:skip Skip the PR/issue when compiling release notes label Mar 23, 2023
@CoenWarmer CoenWarmer changed the title Export observabilityAppId and observabilityFeatureId from plugin [Observability] Extract Exploratory View app into separate app Mar 23, 2023
@CoenWarmer CoenWarmer force-pushed the chore/move-exploratory-view-to-separate-app branch from 51c700c to 6c521e1 Compare March 23, 2023 12:58
@CoenWarmer
Copy link
Contributor Author

@elasticmachine merge upstream

@CoenWarmer CoenWarmer changed the title [Observability] Extract Exploratory View app into separate app [Observability] Copy Exploratory View into a separate app Mar 24, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
exploratoryView - 207 +207

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
exploratoryView - 339 +339
observability 644 646 +2
total +341

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
exploratoryView - 4 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.8MB 3.8MB +14.0B
exploratoryView - 242.5KB ⚠️ +242.5KB
observability 1.1MB 1.1MB +169.0B
synthetics 1.4MB 1.4MB +28.0B
total +242.7KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
exploratoryView - 17 +17

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 31.7KB 32.0KB +346.0B
exploratoryView - 58.4KB +58.4KB
infra 88.0KB 88.3KB +249.0B
observability 88.2KB 88.4KB +148.0B
synthetics 26.6KB 27.0KB +375.0B
ux 5.9KB 6.1KB +243.0B
total +59.7KB
Unknown metric groups

API count

id before after diff
exploratoryView - 342 +342
observability 650 652 +2
total +344

async chunk count

id before after diff
exploratoryView - 12 +12

ESLint disabled in files

id before after diff
exploratoryView - 3 +3

ESLint disabled line counts

id before after diff
exploratoryView - 32 +32
securitySolution 433 436 +3
total +35

References to deprecated APIs

id before after diff
exploratoryView - 66 +66

Total ESLint disabled count

id before after diff
exploratoryView - 35 +35
securitySolution 513 516 +3
total +38

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@CoenWarmer CoenWarmer closed this Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Observability][Synthetics] Move Exploratory View route into a separate app
4 participants